Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

CFNv2: Implement get_template#12865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
simonrw wants to merge2 commits intomain
base:main
Choose a base branch
Loading
fromcfn/v2/get-template
Open

Conversation

simonrw
Copy link
Contributor

@simonrwsimonrw commentedJul 15, 2025•
edited
Loading

Motivation

The new provider does not support theGetTemplate operation. This PR implements an initial version.

Changes

  • Store a copy of the original (parsed but not transformed) template on the stack
  • Implement the provider method basically copying the v1 implementation
  • Unskip 3 tests

@simonrwsimonrw added the semver: patchNon-breaking changes which can be included in patch releases labelJul 15, 2025
@github-actionsGitHub Actions
Copy link

github-actionsbot commentedJul 15, 2025•
edited
Loading

Test Results - Preflight, Unit

21 862 tests  ±0   20 205 ✅ ±0   6m 22s ⏱️ +4s
     1 suites ±0    1 657 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit96caa53. ± Comparison against base commit04aa2bc.

♻️ This comment has been updated with latest results.

@github-actionsGitHub Actions
Copy link

github-actionsbot commentedJul 15, 2025•
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 11s ⏱️ +4s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit96caa53. ± Comparison against base commit04aa2bc.

♻️ This comment has been updated with latest results.

@github-actionsGitHub Actions
Copy link

github-actionsbot commentedJul 15, 2025•
edited
Loading

LocalStack Community integration with Pro

  2 files  ±    0    2 suites  ±0   22m 34s ⏱️ - 1h 23m 59s
895 tests  - 4 034  331 ✅  - 3 821  564 💤  - 213  0 ❌ ±0 
897 runs   - 4 034  331 ✅  - 3 821  566 💤  - 213  0 ❌ ±0 

Results for commit96caa53. ± Comparison against base commit04aa2bc.

This pull requestremoves 4034 tests.
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodbtests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crudtests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_bookstests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setuptests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_snstests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infratests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_tabletests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]…

♻️ This comment has been updated with latest results.

@github-actionsGitHub Actions
Copy link

github-actionsbot commentedJul 15, 2025•
edited
Loading

Test Results (amd64) - Integration, Bootstrap

  5 files    5 suites   34m 24s ⏱️
919 tests 356 ✅ 563 💤 0 ❌
925 runs  356 ✅ 569 💤 0 ❌

Results for commit96caa53.

♻️ This comment has been updated with latest results.

@simonrwsimonrw marked this pull request as ready for reviewJuly 17, 2025 15:34
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@dominikschubertdominikschubertAwaiting requested review from dominikschubertdominikschubert is a code owner

@pinzonpinzonAwaiting requested review from pinzonpinzon is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
semver: patchNon-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@simonrw
[8]ページ先頭
©2009-2025 Movatter.jp