Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

SES: add snapshot test for describe_configuration_set with SNS destinations#12814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
dmacvicar wants to merge1 commit intomain
base:main
Choose a base branch
Loading
from12722-ses-describe-config-set-event-destination

Conversation

dmacvicar
Copy link

@dmacvicardmacvicar commentedJun 29, 2025•
edited
Loading

Motivation

As reported in#12722,describe_configuration_set is missing SNS event destinations.

This is addressed ingetmoto/moto#9023 and this PR complements the parity enhancement with a snapshot test.

Changes

Only tests.

Testing

  • Snapshot test to validate the destinations are there when setting them for a configuration set.

TODO

@dmacvicardmacvicar self-assigned thisJun 29, 2025
@dmacvicardmacvicar added the semver: patchNon-breaking changes which can be included in patch releases labelJun 29, 2025
@localstack-bot
Copy link
Contributor

localstack-bot commentedJun 29, 2025•
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by theCLA Assistant Lite bot.

Copy link
Contributor

@localstack-botlocalstack-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining ourSlack Community and share your PR on the#community channel to share your contributions with us. Please make sure you are following ourcontributing guidelines and ourCode of Conduct.

@dmacvicardmacvicarforce-pushed the12722-ses-describe-config-set-event-destination branch fromf699351 to7684f3aCompareJune 29, 2025 14:37
@dmacvicar
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

localstack-bot added a commit that referenced this pull requestJun 29, 2025
@github-actionsGitHub Actions
Copy link

github-actionsbot commentedJun 29, 2025•
edited
Loading

LocalStack Community integration with Pro

  2 files  ±    0    2 suites  ±0   2m 44s ⏱️ - 1h 42m 48s
156 tests  - 4 750  150 ✅  - 3 980  5 💤  - 771  1 ❌ +1 
158 runs   - 4 750  150 ✅  - 3 980  7 💤  - 771  1 ❌ +1 

For more details on these failures, seethis check.

Results for commit67618e2. ± Comparison against base commit05a922a.

This pull requestremoves 4751 andadds 1 tests.Note that renamed tests count towards both.
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodbtests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crudtests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_bookstests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setuptests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_snstests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infratests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_tabletests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]…
tests.aws.services.ses.test_ses.TestSES ‑ test_describe_config_set_event_destinations

♻️ This comment has been updated with latest results.

@github-actionsGitHub Actions
Copy link

github-actionsbot commentedJun 29, 2025•
edited
Loading

Test Results - Preflight, Unit

21 744 tests  ±0   20 087 ✅ ±0   6m 27s ⏱️ +10s
     1 suites ±0    1 657 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit67618e2. ± Comparison against base commit05a922a.

♻️ This comment has been updated with latest results.

@github-actionsGitHub Actions
Copy link

github-actionsbot commentedJun 29, 2025•
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 20s ⏱️ +13s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit67618e2. ± Comparison against base commit05a922a.

♻️ This comment has been updated with latest results.

@github-actionsGitHub Actions
Copy link

github-actionsbot commentedJun 29, 2025•
edited
Loading

Test Results (amd64) - Integration, Bootstrap

  5 files    5 suites   11m 47s ⏱️
180 tests 174 ✅  5 💤 1 ❌
186 runs  174 ✅ 11 💤 1 ❌

For more details on these failures, seethis check.

Results for commit67618e2.

♻️ This comment has been updated with latest results.

@dmacvicardmacvicarforce-pushed the12722-ses-describe-config-set-event-destination branch from7684f3a to67618e2CompareJune 29, 2025 20:41
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@localstack-botlocalstack-botlocalstack-bot left review comments

@viren-nadkarniviren-nadkarniAwaiting requested review from viren-nadkarniviren-nadkarni will be requested when the pull request is marked ready for reviewviren-nadkarni is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@dmacvicardmacvicar

Labels
semver: patchNon-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@dmacvicar@localstack-bot
[8]ページ先頭
©2009-2025 Movatter.jp