Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

CFNv2: support dynamic parameter resolution#12797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
simonrw wants to merge8 commits intocfn/v2/describe-parameters
base:cfn/v2/describe-parameters
Choose a base branch
Loading
fromcfn/v2/dynamic-ssm-lookup

Conversation

simonrw
Copy link
Contributor

@simonrwsimonrw commentedJun 24, 2025•
edited
Loading

Motivation

The V2 engine does not currently support resolving dynamic parameter values, e.g.

{{resolve:secretsmanager:secret-id:secret-string:json-key:version-stage:version-id}}

Changes

  • Extract relevant functions out of the template deployer into their own module
  • Replace/resolve dynamic references when visiting node properties in the preprocessor
  • Unskip ssm resolving test in template engine tests

@simonrwsimonrw added the semver: minorNon-breaking changes which can be included in minor releases, but not in patch releases labelJun 24, 2025
@github-actionsGitHub Actions
Copy link

github-actionsbot commentedJun 24, 2025•
edited
Loading

Test Results - Preflight, Unit

21 727 tests  ±0   20 070 ✅ ±0   6m 23s ⏱️ -50s
     1 suites ±0    1 657 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit6574897. ± Comparison against base commit6c4cd17.

♻️ This comment has been updated with latest results.

@github-actionsGitHub Actions
Copy link

github-actionsbot commentedJun 24, 2025•
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 7s ⏱️ -1s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit6574897. ± Comparison against base commit6c4cd17.

♻️ This comment has been updated with latest results.

@github-actionsGitHub Actions
Copy link

github-actionsbot commentedJun 24, 2025•
edited
Loading

LocalStack Community integration with Pro

  2 files  ±0    2 suites  ±0   21m 27s ⏱️ -2s
887 tests ±0  323 ✅ ±0  564 💤 ±0  0 ❌ ±0 
889 runs  ±0  323 ✅ ±0  566 💤 ±0  0 ❌ ±0 

Results for commit6574897. ± Comparison against base commit6c4cd17.

♻️ This comment has been updated with latest results.

@github-actionsGitHub Actions
Copy link

github-actionsbot commentedJun 24, 2025•
edited
Loading

Test Results (amd64) - Integration, Bootstrap

  5 files  ±0    5 suites  ±0   34m 14s ⏱️ -20s
911 tests ±0  348 ✅ ±0  563 💤 ±0  0 ❌ ±0 
917 runs  ±0  348 ✅ ±0  569 💤 ±0  0 ❌ ±0 

Results for commit6574897. ± Comparison against base commit6c4cd17.

♻️ This comment has been updated with latest results.

@simonrwsimonrwforce-pushed thecfn/v2/dynamic-ssm-lookup branch fromacc5133 to6574897CompareJune 24, 2025 22:06
@simonrwsimonrw marked this pull request as ready for reviewJune 24, 2025 22:58
@simonrwsimonrw requested a review fromMEPalmaJune 24, 2025 22:58
@@ -1040,7 +1045,23 @@ def visit_node_array(self, node_array: NodeArray) -> PreprocEntityDelta:
return PreprocEntityDelta(before=before, after=after)

def visit_node_property(self, node_property: NodeProperty) -> PreprocEntityDelta:
return self.visit(node_property.value)
# TODO: is this the right place?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Are dynamic parameters only resolved at a property level? For example, these are never resolved as input for another intrinsic function?

@simonrwsimonrw added this to thePlayground milestoneJun 30, 2025
@simonrwsimonrwforce-pushed thecfn/v2/describe-parameters branch from6c4cd17 to2ac855dCompareJuly 3, 2025 15:31
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@MEPalmaMEPalmaMEPalma left review comments

@dominikschubertdominikschubertAwaiting requested review from dominikschubertdominikschubert is a code owner

@pinzonpinzonAwaiting requested review from pinzonpinzon is a code owner

Assignees
No one assigned
Labels
semver: minorNon-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
Playground
Development

Successfully merging this pull request may close these issues.

2 participants
@simonrw@MEPalma
[8]ページ先頭
©2009-2025 Movatter.jp