Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

add support for Fn::Transform in CFn v2#12689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
pinzon wants to merge19 commits intomain
base:main
Choose a base branch
Loading
fromcfn/test/fn-transform-include

Conversation

pinzon
Copy link
Member

@pinzonpinzon commentedMay 29, 2025•
edited
Loading

Motivation

This PR adds support of resolving and executing Fn::Transform intrinsic functions in the new CloudFormation engine v2. For both: AWS::Include and user defined Macros.

Changes

  • Add capabilities of resolving function in the ChangeSetModelTransform class.

Testing

  • New AWS validated tests to confirm that the function works with change sets.

@github-actionsGitHub Actions
Copy link

github-actionsbot commentedMay 29, 2025•
edited
Loading

Test Results - Preflight, Unit

21 862 tests  ±0   20 205 ✅ ±0   6m 22s ⏱️ +4s
     1 suites ±0    1 657 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit4b41da3. ± Comparison against base commit04aa2bc.

♻️ This comment has been updated with latest results.

@github-actionsGitHub Actions
Copy link

github-actionsbot commentedMay 29, 2025•
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 9s ⏱️ +2s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit4b41da3. ± Comparison against base commit04aa2bc.

♻️ This comment has been updated with latest results.

@github-actionsGitHub Actions
Copy link

github-actionsbot commentedMay 29, 2025•
edited
Loading

Test Results - Alternative Providers

1 000 tests  +12   625 ✅ +4   36m 51s ⏱️ + 3m 4s
    4 suites ± 0   366 💤  - 1 
    4 files   ± 0     9 ❌ +9 

For more details on these failures, seethis check.

Results for commite3384dd. ± Comparison against base commit6348947.

This pull requestskips 4 andun-skips 5 tests.
tests.aws.services.cloudformation.v2.ported_from_v1.api.test_changesets ‑ test_autoexpand_capability_requirementtests.aws.services.cloudformation.v2.ported_from_v1.resources.test_stack_sets ‑ test_create_stack_set_with_stack_instancestests.aws.services.cloudformation.v2.ported_from_v1.test_template_engine.TestMacros ‑ test_error_pass_macro_as_referencetests.aws.services.cloudformation.v2.ported_from_v1.test_template_engine.TestMacros ‑ test_to_validate_template_limit_for_macro
tests.aws.services.cloudformation.v2.ported_from_v1.api.test_stacks.TestStacksApi ‑ test_update_stack_with_same_template_withoutchangetests.aws.services.cloudformation.v2.ported_from_v1.api.test_templates ‑ test_create_stack_from_s3_template_url[http_host]tests.aws.services.cloudformation.v2.ported_from_v1.api.test_templates ‑ test_create_stack_from_s3_template_url[http_invalid]tests.aws.services.cloudformation.v2.ported_from_v1.api.test_templates ‑ test_create_stack_from_s3_template_url[http_path]tests.aws.services.cloudformation.v2.ported_from_v1.api.test_templates ‑ test_create_stack_from_s3_template_url[s3_url]

♻️ This comment has been updated with latest results.

@github-actionsGitHub Actions
Copy link

github-actionsbot commentedMay 29, 2025•
edited
Loading

LocalStack Community integration with Pro

    2 files  ± 0      2 suites  ±0   1h 42m 27s ⏱️ - 4m 6s
4 941 tests +12  4 152 ✅ ±0  789 💤 +12  0 ❌ ±0 
4 943 runs  +12  4 152 ✅ ±0  791 💤 +12  0 ❌ ±0 

Results for commit4b41da3. ± Comparison against base commit04aa2bc.

♻️ This comment has been updated with latest results.

@github-actionsGitHub Actions
Copy link

github-actionsbot commentedMay 29, 2025•
edited
Loading

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 23m 1s ⏱️
5 300 tests 4 357 ✅ 942 💤 1 ❌
5 306 runs  4 357 ✅ 948 💤 1 ❌

For more details on these failures, seethis check.

Results for commit4b41da3.

♻️ This comment has been updated with latest results.

@pinzonpinzonforce-pushed thecfn/test/fn-transform-include branch 2 times, most recently fromc450be1 to7bd5f66CompareJune 2, 2025 15:45
@tiurintiurin added this to thePlayground milestoneJun 4, 2025
@pinzonpinzonforce-pushed thecfn/test/fn-transform-include branch from4aa21fe to8b24925CompareJune 20, 2025 19:35
@pinzonpinzonforce-pushed thecfn/test/fn-transform-include branch 3 times, most recently from57aef60 to6d9299dCompareJuly 2, 2025 18:09
@pinzonpinzonforce-pushed thecfn/test/fn-transform-include branch fromeee09b0 toa61e2bbCompareJuly 14, 2025 15:07
@pinzonpinzon changed the titlewip: add tests for Fn::Transform in change setsadd support for Fn::Transform in CFn v2Jul 15, 2025
@pinzonpinzon added the semver: minorNon-breaking changes which can be included in minor releases, but not in patch releases labelJul 15, 2025
@pinzonpinzonforce-pushed thecfn/test/fn-transform-include branch from9b55a00 to4b41da3CompareJuly 17, 2025 14:40
@localstack-bot
Copy link
Contributor

Currently, only patch changes are allowed on main. Your PR labels (semver: minor) indicate that it cannot be merged into the main at this time.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@dominikschubertdominikschubertAwaiting requested review from dominikschubertdominikschubert will be requested when the pull request is marked ready for reviewdominikschubert is a code owner

@simonrwsimonrwAwaiting requested review from simonrwsimonrw will be requested when the pull request is marked ready for reviewsimonrw is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
semver: minorNon-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
Playground
Development

Successfully merging this pull request may close these issues.

3 participants
@pinzon@localstack-bot@tiurin
[8]ページ先頭
©2009-2025 Movatter.jp