Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Include CFn tests in test selection#12518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
simonrw wants to merge12 commits intomain
base:main
Choose a base branch
Loading
fromtest-selection/include-cfn-tests-in-service-tests

Conversation

simonrw
Copy link
Contributor

  • Ensure CloudFormation tests are executed on service changes

Motivation

TBD

Changes

  • Move test files
  • Validate api gateway tests
  • Revalidate tests

@simonrwsimonrw added the semver: patchNon-breaking changes which can be included in patch releases labelApr 11, 2025
@simonrwsimonrw self-assigned thisApr 11, 2025
@simonrwsimonrwforce-pushed thetest-selection/include-cfn-tests-in-service-tests branch from2164675 toa7b9f5aCompareApril 11, 2025 15:59
@github-actionsGitHub Actions
Copy link

github-actionsbot commentedApr 11, 2025•
edited
Loading

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 53m 40s ⏱️ - 2m 43s
4 354 tests  - 3  4 008 ✅  - 3  346 💤 ±0  0 ❌ ±0 
4 360 runs  +1  4 012 ✅ +1  348 💤 ±0  0 ❌ ±0 

Results for commit0a67334. ± Comparison against base commit5ad7f8e.

This pull requestremoves 136 andadds 133 tests.Note that renamed tests count towards both.
tests.aws.services.cloudformation.resources.test_acm ‑ test_cfn_acm_certificatetests.aws.services.cloudformation.resources.test_apigateway ‑ test_accounttests.aws.services.cloudformation.resources.test_apigateway ‑ test_api_gateway_with_policy_as_dicttests.aws.services.cloudformation.resources.test_apigateway ‑ test_cfn_apigateway_aws_integrationtests.aws.services.cloudformation.resources.test_apigateway ‑ test_cfn_apigateway_rest_apitests.aws.services.cloudformation.resources.test_apigateway ‑ test_cfn_apigateway_swagger_importtests.aws.services.cloudformation.resources.test_apigateway ‑ test_cfn_deploy_apigateway_from_s3_swaggertests.aws.services.cloudformation.resources.test_apigateway ‑ test_cfn_deploy_apigateway_integrationtests.aws.services.cloudformation.resources.test_apigateway ‑ test_cfn_deploy_apigateway_modelstests.aws.services.cloudformation.resources.test_apigateway ‑ test_cfn_with_apigateway_resources…
tests.aws.services.acm.resources.test_acm ‑ test_cfn_acm_certificatetests.aws.services.apigateway.resources.test_apigateway ‑ test_accounttests.aws.services.apigateway.resources.test_apigateway ‑ test_api_gateway_with_policy_as_dicttests.aws.services.apigateway.resources.test_apigateway ‑ test_cfn_apigateway_aws_integrationtests.aws.services.apigateway.resources.test_apigateway ‑ test_cfn_apigateway_rest_apitests.aws.services.apigateway.resources.test_apigateway ‑ test_cfn_apigateway_swagger_importtests.aws.services.apigateway.resources.test_apigateway ‑ test_cfn_deploy_apigateway_from_s3_swaggertests.aws.services.apigateway.resources.test_apigateway ‑ test_cfn_deploy_apigateway_integrationtests.aws.services.apigateway.resources.test_apigateway ‑ test_cfn_deploy_apigateway_modelstests.aws.services.apigateway.resources.test_apigateway ‑ test_cfn_with_apigateway_resources…
This pull requestremoves 5 skipped tests andadds 5 skipped tests.Note that renamed tests count towards both.
tests.aws.services.cloudformation.resources.test_ec2 ‑ test_cfn_update_ec2_instance_typetests.aws.services.cloudformation.resources.test_lambda ‑ test_lambda_vpctests.aws.services.cloudformation.resources.test_opensearch ‑ test_domaintests.aws.services.cloudformation.resources.test_redshift ‑ test_redshift_clustertests.aws.services.cloudformation.resources.test_stepfunctions ‑ test_retry_and_catch
tests.aws.services.ec2.resources.test_ec2 ‑ test_cfn_update_ec2_instance_typetests.aws.services.lambda_.resources.test_lambda ‑ test_lambda_vpctests.aws.services.opensearch.resources.test_opensearch ‑ test_domaintests.aws.services.redshift.resources.test_redshift ‑ test_redshift_clustertests.aws.services.stepfunctions.resources.test_stepfunctions ‑ test_retry_and_catch

♻️ This comment has been updated with latest results.

@simonrwsimonrwforce-pushed thetest-selection/include-cfn-tests-in-service-tests branch from3ee0658 to10956faCompareApril 11, 2025 21:08
@github-actionsGitHub Actions
Copy link

github-actionsbot commentedApr 11, 2025•
edited
Loading

S3 Image Test Results (AMD64 / ARM64)

  2 files    2 suites   8m 27s ⏱️
488 tests 438 ✅  50 💤 0 ❌
976 runs  876 ✅ 100 💤 0 ❌

Results for commit0a67334.

♻️ This comment has been updated with latest results.

@simonrwsimonrwforce-pushed thetest-selection/include-cfn-tests-in-service-tests branch 2 times, most recently fromc859eca to0a67334CompareApril 14, 2025 16:20
@simonrwsimonrwforce-pushed thetest-selection/include-cfn-tests-in-service-tests branch from0a67334 to5432c3fCompareApril 16, 2025 15:30
@simonrwsimonrw added this to thePlayground milestoneApr 25, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@MEPalmaMEPalmaAwaiting requested review from MEPalmaMEPalma will be requested when the pull request is marked ready for reviewMEPalma is a code owner

@joe4devjoe4devAwaiting requested review from joe4devjoe4dev will be requested when the pull request is marked ready for reviewjoe4dev is a code owner

@gregfurmangregfurmanAwaiting requested review from gregfurmangregfurman will be requested when the pull request is marked ready for reviewgregfurman is a code owner

@dominikschubertdominikschubertAwaiting requested review from dominikschubertdominikschubert will be requested when the pull request is marked ready for reviewdominikschubert is a code owner

@thrauthrauAwaiting requested review from thrauthrau will be requested when the pull request is marked ready for reviewthrau is a code owner

@baermatbaermatAwaiting requested review from baermatbaermat will be requested when the pull request is marked ready for reviewbaermat is a code owner

@bentskubentskuAwaiting requested review from bentskubentsku will be requested when the pull request is marked ready for reviewbentsku is a code owner

@macnev2013macnev2013Awaiting requested review from macnev2013macnev2013 will be requested when the pull request is marked ready for reviewmacnev2013 is a code owner

@k-a-ilk-a-ilAwaiting requested review from k-a-ilk-a-il will be requested when the pull request is marked ready for reviewk-a-il is a code owner

@giogranogiogranoAwaiting requested review from giogranogiograno will be requested when the pull request is marked ready for reviewgiograno is a code owner

@alexrashedalexrashedAwaiting requested review from alexrashedalexrashed will be requested when the pull request is marked ready for reviewalexrashed is a code owner

@silv-iosilv-ioAwaiting requested review from silv-iosilv-io will be requested when the pull request is marked ready for reviewsilv-io is a code owner

@pinzonpinzonAwaiting requested review from pinzonpinzon will be requested when the pull request is marked ready for reviewpinzon is a code owner

@steffyPsteffyPAwaiting requested review from steffyPsteffyP will be requested when the pull request is marked ready for reviewsteffyP is a code owner

@dfangldfanglAwaiting requested review from dfangldfangl will be requested when the pull request is marked ready for reviewdfangl is a code owner

@sannya-singalsannya-singalAwaiting requested review from sannya-singalsannya-singal will be requested when the pull request is marked ready for reviewsannya-singal is a code owner

@maxhoheisermaxhoheiserAwaiting requested review from maxhoheisermaxhoheiser will be requested when the pull request is marked ready for reviewmaxhoheiser is a code owner

@viren-nadkarniviren-nadkarniAwaiting requested review from viren-nadkarniviren-nadkarni will be requested when the pull request is marked ready for reviewviren-nadkarni is a code owner

@cloutierMatcloutierMatAwaiting requested review from cloutierMatcloutierMat will be requested when the pull request is marked ready for reviewcloutierMat is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@simonrwsimonrw

Labels
semver: patchNon-breaking changes which can be included in patch releases
Projects
None yet
Milestone
Playground
Development

Successfully merging this pull request may close these issues.

1 participant
@simonrw
[8]ページ先頭
©2009-2025 Movatter.jp