- Notifications
You must be signed in to change notification settings - Fork124
Fix resulting buffer from BufferProxy's out method being ignored.#255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
LambdAurora wants to merge2 commits intolmdbjava:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
TODO: address failing dbiWithComparatorThreadSafetyByteArray test.
This proves to be more reliable than Agreno's UnsafeBuffers.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request aims to fix some cases in LMDBJava where the
BufferProxy'soutmethod resulting buffer is ignored, especially inDbi.I've discovered this issue while attempting to write a new implementation of
BufferProxyto use Java 22's Function Foreign Memory API in preparation of Java 25's removal of various methods inUnsafeinvalidating most fastBufferProxyimplementations. The implementation failed to pass some tests since in theoutmethod I returned a newByteBuffer(taking advantage ofMemorySegment.ofAddress().asByteBuffer()).After further investigation, I've found that
ByteArrayProxyalso relies on returning a different "buffer" from the one that's given as an argument, for which I've added new tests that reproduce the behavior ofDbiTest.customComparatorandDbiTest.dbiWithComparatorThreadSafetyusing byte arrays instead.ByteArrayProxyled me to think that returning a different buffer inoutis an allowed and intended behavior.This fix is important for users of
ByteArrayProxyand allows for a stop-gap external implementation ofBufferProxyusing the FFM API to allow users to upgrade to Java 25 when the time comes until a proper resolution to#42 comes around.