Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix resulting buffer from BufferProxy's out method being ignored.#255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@LambdAurora
Copy link
Contributor

@LambdAuroraLambdAurora commentedJul 9, 2025
edited
Loading

This pull request aims to fix some cases in LMDBJava where theBufferProxy'sout method resulting buffer is ignored, especially inDbi.

I've discovered this issue while attempting to write a new implementation ofBufferProxy to use Java 22's Function Foreign Memory API in preparation of Java 25's depreciation of various methods inUnsafe invalidating most fastBufferProxy implementations. The implementation failed to pass some tests since in theout method I returned a newByteBuffer (taking advantage ofMemorySegment.ofAddress().asByteBuffer()).

After further investigation, I've found thatByteArrayProxy also relies on returning a different "buffer" from the one that's given as an argument, for which I've added new tests that reproduce the behavior ofDbiTest.customComparator andDbiTest.dbiWithComparatorThreadSafety using byte arrays instead.ByteArrayProxy led me to think that returning a different buffer inout is an allowed and intended behavior.

This fix is important for users ofByteArrayProxy and allows for a stop-gap external implementation ofBufferProxy using the FFM API to allow users to upgrade to Java 25 when the time comes until a proper resolution to#42 comes around.

TODO: address failing dbiWithComparatorThreadSafetyByteArray test.
This proves to be more reliable than Agreno's UnsafeBuffers.
@at055612
Copy link
Collaborator

Regarding the upgrade to Java 25, see#259

I will however try and verify and merge this PR as soon as possible.

LambdAurora reacted with hooray emoji

@codecov
Copy link

codecovbot commentedOct 26, 2025
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.33%. Comparing base (0b741e8) to head (58a489f).

Additional details and impacted files
@@             Coverage Diff              @@##             master     #255      +/-   ##============================================+ Coverage     88.60%   89.33%   +0.72%- Complexity      409      413       +4============================================  Files            32       32                Lines          1483     1481       -2       Branches        124      124              ============================================+ Hits           1314     1323       +9+ Misses          100       88      -12- Partials         69       70       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@at055612at055612 merged commit43ac84f intolmdbjava:masterOct 26, 2025
21 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LambdAurora@at055612

[8]ページ先頭

©2009-2025 Movatter.jp