- Notifications
You must be signed in to change notification settings - Fork124
Support User Defined PooledByteBufAllocator#162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This patch allows users to pass a PooledByteBufAllocator instanceif they wish to not use the DEFAULT instance. Also, this patchfixes a minor bug where a ByteBuf is created during initializationwithout ever being released.
codecov-commenter commentedAug 18, 2020
Codecov Report
@@ Coverage Diff @@## master #162 +/- ##============================================+ Coverage 90.93% 91.06% +0.12%+ Complexity 383 382 -1============================================ Files 30 30 Lines 1346 1343 -3 Branches 118 116 -2 ============================================- Hits 1224 1223 -1 Misses 58 58+ Partials 64 62 -2
Continue to review full report at Codecov.
|
Thank you@Maithem. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch allows users to pass a PooledByteBufAllocator instance
if they wish to not use the DEFAULT instance. Also, this patch
fixes a minor bug where a ByteBuf is created during initialization
without ever being released.