- Notifications
You must be signed in to change notification settings - Fork14.5k
[flang][CMake] CYGWIN: Fix undefined references at link time.#67105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
That's the right thing to do but needs a rebase. |
While building the source of flang on CYGWIN, the process suddently stopped with lot of "Undefined reference" errors at link time. According to the statement that a shared library can't have undefined references on Windows, I applied the same fix to CYGWIN with this patch.
44fe446 tobe4d868CompareStill unresolved in llvm-20.1.8. |
@jeremyd2019 could you review it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
@carlo-bramini do you have write access? If not, you can ask the reviewer to merge it for you, but you should change to a proper email address first:https://llvm.org/docs/DeveloperPolicy.html#email-addresses |
Than you very much for your replies.
No, I have not.
The "Keep my email addresses private" option in my setting is already OFF. |
you might need to amend the commit with |
While building the source of flang on CYGWIN, the process suddently stopped with lot of "Undefined reference" errors at link time.
According to the statement that a shared library can't have undefined references on Windows, I applied the same fix to CYGWIN with this patch.