- Notifications
You must be signed in to change notification settings - Fork14.5k
[LifetimeSafety] Enhance benchmark script for ExpiredLoans analysis#149577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
usx95 wants to merge1 commit intousers/usx95/07-14-users_usx95_lifetime-safety-add-loan-expiryChoose a base branch
base:users/usx95/07-14-users_usx95_lifetime-safety-add-loan-expiry
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+157 −81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This was referencedJul 18, 2025
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stackon Graphite.
This stack of pull requests is managed byGraphite. Learn more aboutstacking. |
You can test this locally with the following command:darker --check --diff -r HEAD~1...HEAD clang/test/Analysis/LifetimeSafety/benchmark.py View the diff from darker here.--- benchmark.py2025-07-18 19:49:32.000000 +0000+++ benchmark.py2025-07-18 19:51:58.973643 +0000@@ -115,20 +115,20 @@ return "// Nesting depth must be positive." cpp_code = "struct MyObj { int id; ~MyObj() {} };\n\n" cpp_code += f"void nested_loops_{n}() {{\n" cpp_code += " MyObj* p = nullptr;\n"-+ for i in range(n): indent = " " * (i + 1) cpp_code += f"{indent}for(int i{i}=0; i{i}<2; ++i{i}) {{\n" cpp_code += f"{indent} MyObj s{i}; p = &s{i};\n" for i in range(n - 1, -1, -1): indent = " " * (i + 1) cpp_code += f"{indent}}}\n"-+ cpp_code += "}\n" cpp_code += f"\nint main() {{ nested_loops_{n}(); return 0; }}\n" return cpp_code@@ -238,18 +238,18 @@ report.append(" ".join(row)) report.append("\n**Complexity Analysis:**\n") report.append("| Analysis Phase | Complexity O(n<sup>k</sup>) |") report.append("|:------------------|:--------------------------|")-+ analysis_phases = { "Total Analysis": data["lifetime_ms"], "FactGenerator": data["fact_gen_ms"], "LoanPropagation": data["loan_prop_ms"], "ExpiredLoans": data["expired_loans_ms"], }-+ for phase_name, y_data in analysis_phases.items(): k, delta = calculate_complexity(n_data, np.array(y_data)) if k is not None and delta is not None: complexity_str = f"O(n<sup>{k:.2f}</sup> ± {delta:.2f})" else:@@ -291,11 +291,13 @@ print(f"Compilation failed for N={n}!", file=sys.stderr) print(result.stderr, file=sys.stderr) return {} durations_us = analyze_trace_file(trace_file)- return {key.replace('_us', '_ms'): value / 1000.0 for key, value in durations_us.items()}+ return {+ key.replace("_us", "_ms"): value / 1000.0 for key, value in durations_us.items()+ } if __name__ == "__main__": parser = argparse.ArgumentParser( description="Generate, compile, and benchmark C++ test cases for Clang's lifetime analysis."@@ -360,11 +362,11 @@ ) if durations_ms: results[test_name]["n"].append(n) for key, value in durations_ms.items(): results[test_name][key].append(value)-+ print( f" Total Analysis: {human_readable_time(durations_ms['lifetime_ms'])} | " f"FactGen: {human_readable_time(durations_ms['fact_gen_ms'])} | " f"LoanProp: {human_readable_time(durations_ms['loan_prop_ms'])} | " f"ExpiredLoans: {human_readable_time(durations_ms['expired_loans_ms'])}"@@ -374,10 +376,10 @@ print("Generating Markdown Report...") print("=" * 80 + "\n") markdown_report = generate_markdown_report(results) print(markdown_report)-+ report_filename = os.path.join(args.output_dir, "performance_report.md") with open(report_filename, "w") as f: f.write(markdown_report) print(f"Report saved to: {report_filename}") |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Enhanced the lifetime safety analysis benchmark script with more detailed performance metrics and a new nested loop test case. This is a worst case for loan expiry analysis.
What changed?
nested_loopsthat generates code with N levels of nested loops to test how analysis performance scales with loop nesting depthReport
Lifetime Analysis Performance Report
Test Case: Pointer Cycle in Loop
Relative Timing Results (% of Total Clang Time):
Complexity Analysis:
Test Case: CFG Merges
Relative Timing Results (% of Total Clang Time):
Complexity Analysis:
Test Case: Deeply Nested Loops
Relative Timing Results (% of Total Clang Time):
Complexity Analysis: