- Notifications
You must be signed in to change notification settings - Fork14.5k
[libcxx] Switch to release branch runners#149385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
boomanaiden154 wants to merge1 commit intollvm:release/21.xChoose a base branch
base:release/21.x
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
[libcxx] Switch to release branch runners#149385
boomanaiden154 wants to merge1 commit intollvm:release/21.xfromboomanaiden154:libcxx-release-branch-runners-21x
+8 −8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This ensures that if/when we bump the toolchain versions in the maincontainer that we do not break tests on the release branch.
Member
llvmbot commentedJul 17, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@llvm/pr-subscribers-libcxx @llvm/pr-subscribers-github-workflow Author: Aiden Grossman (boomanaiden154) ChangesThis ensures that if/when we bump the toolchain versions in the main container that we do not break tests on the release branch. Full diff:https://github.com/llvm/llvm-project/pull/149385.diff 1 Files Affected:
diff --git a/.github/workflows/libcxx-build-and-test.yaml b/.github/workflows/libcxx-build-and-test.yamlindex ec937de02ca1a..a5be912b1ab07 100644--- a/.github/workflows/libcxx-build-and-test.yaml+++ b/.github/workflows/libcxx-build-and-test.yaml@@ -36,7 +36,7 @@ concurrency: jobs: stage1: if: github.repository_owner == 'llvm'- runs-on: llvm-premerge-libcxx-runners+ runs-on: llvm-premerge-libcxx-release-runners continue-on-error: false strategy: fail-fast: false@@ -73,7 +73,7 @@ jobs: **/crash_diagnostics/* stage2: if: github.repository_owner == 'llvm'- runs-on: llvm-premerge-libcxx-runners+ runs-on: llvm-premerge-libcxx-release-runners needs: [ stage1 ] continue-on-error: false strategy:@@ -147,19 +147,19 @@ jobs: 'generic-static', 'bootstrapping-build' ]- machine: [ 'llvm-premerge-libcxx-runners' ]+ machine: [ 'llvm-premerge-libcxx-release-runners' ] include: - config: 'generic-cxx26'- machine: llvm-premerge-libcxx-runners+ machine: llvm-premerge-libcxx-release-runners - config: 'generic-asan'- machine: llvm-premerge-libcxx-runners+ machine: llvm-premerge-libcxx-release-runners - config: 'generic-tsan'- machine: llvm-premerge-libcxx-runners+ machine: llvm-premerge-libcxx-release-runners - config: 'generic-ubsan'- machine: llvm-premerge-libcxx-runners+ machine: llvm-premerge-libcxx-release-runners # Use a larger machine for MSAN to avoid timeout and memory allocation issues. - config: 'generic-msan'- machine: llvm-premerge-libcxx-runners+ machine: llvm-premerge-libcxx-release-runners runs-on: ${{ matrix.machine }} steps: - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 |
tru approved these changesJul 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM! Thanks
cmtice approved these changesJul 17, 2025
ldionne approved these changesJul 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for this! It's nice that it seems to "just work" -- I love it.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that if/when we bump the toolchain versions in the main container that we do not break tests on the release branch.