- Notifications
You must be signed in to change notification settings - Fork14.5k
[Github] Build CI Containers in Stacked PRs#149346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[Github] Build CI Containers in Stacked PRs#149346
Conversation
Currently the pull_request event on the build CI container workflows arerestricted to main. This prevents building them on stacked PRs. This isa bit annoying because we do not get the CI to test that everything isworking until all of the base PRs have landed and the target branchbecomes main.
@llvm/pr-subscribers-github-workflow Author: Aiden Grossman (boomanaiden154) ChangesCurrently the pull_request event on the build CI container workflows are restricted to main. This prevents building them on stacked PRs. This is a bit annoying because we do not get the CI to test that everything is working until all of the base PRs have landed and the target branch becomes main. Full diff:https://github.com/llvm/llvm-project/pull/149346.diff 2 Files Affected:
diff --git a/.github/workflows/build-ci-container-windows.yml b/.github/workflows/build-ci-container-windows.ymlindex 59079f057d021..f76c69f29fb30 100644--- a/.github/workflows/build-ci-container-windows.yml+++ b/.github/workflows/build-ci-container-windows.yml@@ -11,8 +11,6 @@ on: - .github/workflows/build-ci-container-windows.yml - '.github/workflows/containers/github-action-ci-windows/**' pull_request:- branches:- - main paths: - .github/workflows/build-ci-container-windows.yml - '.github/workflows/containers/github-action-ci-windows/**'diff --git a/.github/workflows/build-ci-container.yml b/.github/workflows/build-ci-container.ymlindex 3159aae32ca51..7f01264af8534 100644--- a/.github/workflows/build-ci-container.yml+++ b/.github/workflows/build-ci-container.yml@@ -11,8 +11,6 @@ on: - .github/workflows/build-ci-container.yml - '.github/workflows/containers/github-action-ci/**' pull_request:- branches:- - main paths: - .github/workflows/build-ci-container.yml - '.github/workflows/containers/github-action-ci/**' |
7b541c9 intollvm:mainUh oh!
There was an error while loading.Please reload this page.
Currently the pull_request event on the build CI container workflows are restricted to main. This prevents building them on stacked PRs. This is a bit annoying because we do not get the CI to test that everything is working until all of the base PRs have landed and the target branch becomes main.