[Target] Remove unnecessary casts (NFC)#149342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

kazutakahirata merged 1 commit intollvm:mainfromkazutakahirata:cleanup_20250717_cast_llvm_Target

Jul 17, 2025

Merged

[Target] Remove unnecessary casts (NFC)#149342

kazutakahirata merged 1 commit intollvm:mainfromkazutakahirata:cleanup_20250717_cast_llvm_Target

Jul 17, 2025

Conversation

Copy link

Contributor

kazutakahirata commentedJul 17, 2025

getFunction().getParent() already returns Module *.

[Target] Remove unnecessary casts (NFC)

040c330

getFunction().getParent() already returns Module *.

kazutakahirata requested review fromarsenm,shiltian andtgymnich

July 17, 2025 15:43

llvmbot added backend:ARM backend:AMDGPU labels

Jul 17, 2025

Copy link

Member

llvmbot commentedJul 17, 2025•
edited
Loading

@llvm/pr-subscribers-backend-arm

@llvm/pr-subscribers-backend-amdgpu

Author: Kazu Hirata (kazutakahirata)

Changes

getFunction().getParent() already returns Module *.

Full diff:https://github.com/llvm/llvm-project/pull/149342.diff

2 Files Affected:

(modified) llvm/lib/Target/AMDGPU/SIISelLowering.cpp (+1-1)
(modified) llvm/lib/Target/ARM/ARMISelLowering.cpp (+1-2)

diff --git a/llvm/lib/Target/AMDGPU/SIISelLowering.cpp b/llvm/lib/Target/AMDGPU/SIISelLowering.cppindex dfe6f65d240e6..27212fda7638c 100644--- a/llvm/lib/Target/AMDGPU/SIISelLowering.cpp+++ b/llvm/lib/Target/AMDGPU/SIISelLowering.cpp@@ -9308,7 +9308,7 @@ SDValue SITargetLowering::LowerINTRINSIC_WO_CHAIN(SDValue Op,     return DAG.getNode(AMDGPUISD::PERM, DL, MVT::i32, Op.getOperand(1),                        Op.getOperand(2), Op.getOperand(3));   case Intrinsic::amdgcn_reloc_constant: {-    Module *M = const_cast<Module *>(MF.getFunction().getParent());+    Module *M = MF.getFunction().getParent();     const MDNode *Metadata = cast<MDNodeSDNode>(Op.getOperand(1))->getMD();     auto SymbolName = cast<MDString>(Metadata->getOperand(0))->getString();     auto *RelocSymbol = cast<GlobalVariable>(diff --git a/llvm/lib/Target/ARM/ARMISelLowering.cpp b/llvm/lib/Target/ARM/ARMISelLowering.cppindex 65d1c4e2d6515..8d139883ef913 100644--- a/llvm/lib/Target/ARM/ARMISelLowering.cpp+++ b/llvm/lib/Target/ARM/ARMISelLowering.cpp@@ -3545,8 +3545,7 @@ SDValue ARMTargetLowering::LowerConstantPool(SDValue Op,     auto AFI = DAG.getMachineFunction().getInfo<ARMFunctionInfo>();     auto T = const_cast<Type*>(CP->getType());     auto C = const_cast<Constant*>(CP->getConstVal());-    auto M = const_cast<Module*>(DAG.getMachineFunction().-                                 getFunction().getParent());+    auto M = DAG.getMachineFunction().getFunction().getParent();     auto GV = new GlobalVariable(                     *M, T, /*isConstant=*/true, GlobalVariable::InternalLinkage, C,                     Twine(DAG.getDataLayout().getPrivateGlobalPrefix()) + "CP" +