- Notifications
You must be signed in to change notification settings - Fork14.5k
[mlir][linalg] Enable scalable vectorization of linalg.unpack (WIP)#149293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
banach-space wants to merge1 commit intomainChoose a base branch fromusers/banach-space/linalg/unpack_vec_update
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+114 −35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This patch updates `vectorizeAsTensorUnpackOp` to support scalablevectorization by requiring user-specified vector sizes for both the_read_ and _write_ operations involved in `linalg.unpack`. Detailedrationale and an example are provided below.Conceptually, `linalg.unpack` consists of the following high-level steps: 1. _Read_ from the source tensor. 2. Transpose the value read in step (1). 3. _Write_ the value from step (2) into the destination tensor.Currently, when vectorizing with user-provided vector sizes, only thesizes for the _write_ operation (step 3) are required. Sizes for the_read_ operation (step 1) are inferred from static shapes and inner tilesizes.This logic breaks when the input shapes or tile sizes are dynamic(indeed, `vectorizeUnPackOpPrecondition` rejects such cases ATM and thevectorization fails). This patch addresses the issue by requiringexplicit vector sizes for both the read and write sides, enablingscalable vectorization in such cases.Example:```mlirfunc.func@unpack(%in: tensor<1x1x8x?xf32>, %out: tensor<8x?xf32>) -> tensor<8x?xf32> { %vs = vector.vscale %c8 = arith.constant 8 : index %tile_size = arith.muli %vs, %c8 : index %unpack = linalg.unpack %in inner_dims_pos = [0, 1] inner_tiles = [8, %tile_size] into %out : tensor<1x1x8x?xf32> -> tensor<8x?xf32> return %unpack : tensor<8x?xf32>}module attributes {transform.with_named_sequence} { transform.named_sequence @__transform_main(%arg0: !transform.any_op {transform.readonly}) { %0 = transform.structured.match ops{["linalg.unpack"]} in %arg0 : (!transform.any_op) -> !transform.any_op transform.structured.vectorize %0 vector_sizes [1, 1, 8, [8], 8, [8]] : !transform.any_op // \ / \ / // read-sizes write-sizes transform.yield }}```Finally, this patch also extends `createReadOrMaskedRead` and`createWriteOrMaskedWrite` to take scalable flags.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch updates
vectorizeAsTensorUnpackOp
to support scalable vectorization by requiring user-specified vector sizes for both theread andwrite operations involved inlinalg.unpack
. Detailed rationale and an example are provided below.Conceptually,
linalg.unpack
consists of the following high-level steps:Currently, when vectorizing with user-provided vector sizes, only the sizes for thewrite operation (step 3) are required. Sizes for theread operation (step 1) are inferred from static shapes and inner tile sizes.
This logic breaks when the input shapes or tile sizes are dynamic (indeed,
vectorizeUnPackOpPrecondition
rejects such cases ATM and the vectorization fails). This patch addresses the issue by requiring explicit vector sizes for both the read and write sides, enabling scalable vectorization in such cases.Example:
Finally, this patch also extends
createReadOrMaskedRead
andcreateWriteOrMaskedWrite
to take scalable flags.