- Notifications
You must be signed in to change notification settings - Fork14.5k
[GVN][NFC] Use early return in phiTranslateImpl()#149268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
+9 −6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
@llvm/pr-subscribers-llvm-transforms Author: Madhur Amilkanthwar (madhur13490) ChangesFull diff:https://github.com/llvm/llvm-project/pull/149268.diff 1 Files Affected:
diff --git a/llvm/lib/Transforms/Scalar/GVN.cpp b/llvm/lib/Transforms/Scalar/GVN.cppindex 8bff458f88bb9..affae41ed2c83 100644--- a/llvm/lib/Transforms/Scalar/GVN.cpp+++ b/llvm/lib/Transforms/Scalar/GVN.cpp@@ -2367,12 +2367,15 @@ uint32_t GVNPass::ValueTable::phiTranslateImpl(const BasicBlock *Pred, // See if we can refine the value number by looking at the PN incoming value // for the given predecessor. if (PHINode *PN = NumberingPhi[Num]) {- if (PN->getParent() == PhiBlock)- for (unsigned I = 0; I != PN->getNumIncomingValues(); ++I)- if (PN->getIncomingBlock(I) == Pred)- if (uint32_t TransVal = lookup(PN->getIncomingValue(I), false))- return TransVal;- return Num;+ if (PN->getParent() != PhiBlock)+ return Num;++ for (unsigned I = 0; I != PN->getNumIncomingValues(); ++I) {+ if (PN->getIncomingBlock(I) != Pred)+ continue;+ if (uint32_t TransVal = lookup(PN->getIncomingValue(I), false))+ return TransVal;+ } } if (BasicBlock *BB = NumberingBB[Num]) { |
1d398a9 intollvm:main 9 of 11 checks passed
Uh oh!
There was an error while loading.Please reload this page.
madhur13490 added a commit to madhur13490/llvm-project that referenced this pull requestJul 17, 2025
madhur13490 added a commit that referenced this pull requestJul 17, 2025
LLVM Buildbot has detected a new failure on builder Full details are available at:https://lab.llvm.org/buildbot/#/builders/190/builds/23672 Here is the relevant piece of the build log for the reference |
| continue; | ||
| if (uint32_t TransVal = lookup(PN->getIncomingValue(I), false)) | ||
| return TransVal; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
previously we wouldreturn Num; if no translated incoming value could be found, now we fall through.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes, realized this. Reverted in#149270
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.