- Notifications
You must be signed in to change notification settings - Fork14.5k
Fix objective-c ptrauth tests#149218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
ojhunt wants to merge10,000 commits intollvm:mainChoose a base branch fromswiftlang:users/ojhunt/objc-ptrauth-test-fix
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
+623,958 −17,217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
After changes inllvm#145793./home/david.spickett/llvm-project/lldb/source/Plugins/Disassembler/LLVMC/DisassemblerLLVMC.cpp:1360:49: error: non-const lvalue reference to type 'uint64_t' (aka 'unsigned long long') cannot bind to a value of unrelated type 'size_t' (aka 'unsigned int') 1360 | status = m_disasm_up->getInstruction(mc_inst, size, data, pc, llvm::nulls()); | ^~~~/home/david.spickett/llvm-project/llvm/include/llvm/MC/MCDisassembler/MCDisassembler.h:135:64: note: passing argument to parameter 'Size' here 135 | virtual DecodeStatus getInstruction(MCInst &Instr, uint64_t &Size, | ^1 error generated.The type used in the LLVM method we call is uin64_t so use that instead.It's overkill for what it is, but that's a separate issue if anyone cares.Also removed the unused form of GetMCInst.(cherry picked from commita64bfd8)
Conflicts:clang/lib/Analysis/UnsafeBufferUsage.cpp
…afety attributes are emitted in diagnostics (#10993)A recent auto-merged change from upstreamd9ef62aseemed to remove the special handling on how macro-defined bounds-safetyattributes are emitted in diagnostics. Adding the specialization for nowto fix the test failure. The task to clean up the special handling ofthe macro defined attributes is tracked separately.This fixes test failures in Clang :: BoundsSafety/Sema/attributes_in_template_decls_attr_only_mode.cpp Clang :: BoundsSafety/Sema/complex-typespecs-with-bounds.c Clang :: BoundsSafety/Sema/terminated-by-attr.c Clang :: BoundsSafety/Sema/unsafe-late-const.crdar://155652853
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.