Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[flang] Main program symbol no longer conflicts with the other symbols#149169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
eugeneepshteyn merged 15 commits intollvm:mainfromeugeneepshteyn:main-sym-conflict-4
Jul 17, 2025

Conversation

eugeneepshteyn
Copy link
Contributor

@eugeneepshteyneugeneepshteyn commentedJul 16, 2025•
edited
Loading

The following code is now accepted:

module mendprogram muse mend

The PROGRAM name doesn't really have an effect on the compilation result, so it shouldn't result in symbol name conflicts.

This change makes the main program symbol name all uppercase in the cooked character stream. This makes it distinct from all other symbol names that are all lowercase in cooked character stream.

Modified the tests that were checking for lower case main program name.

@github-actionsGitHub Actions
Copy link

⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo.
Please turn offKeep my email addresses private setting in your account.
SeeLLVM Developer Policy andLLVM Discourse for more information.

@eugeneepshteyn
Copy link
ContributorAuthor

eugeneepshteyn commentedJul 16, 2025•
edited
Loading

⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo. Please turn offKeep my email addresses private setting in your account. SeeLLVM Developer Policy andLLVM Discourse for more information.

I'm not using private e-mail address.

@eugeneepshteyneugeneepshteyn marked this pull request as ready for reviewJuly 16, 2025 19:21
// Uppercase the name of the main program, so that its symbol name
// would be unique from similarly named non-main-program symbols.
auto upperCaseCharBlock = [](const parser::CharBlock &cb) {
char *ch = const_cast<char *>(cb.begin());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please always use braced initialization in the bits of flang-new that are modern C++.

}
const parser::CharBlock *endName{GetStmtName(
std::get<parser::Statement<parser::EndProgramStmt>>(mainProgram.t))};
if (endName) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

these twoif statements could each be combined with the preceding local variable declarations.

@eugeneepshteyneugeneepshteyn merged commit413e71b intollvm:mainJul 17, 2025
10 checks passed
@eugeneepshteyneugeneepshteyn deleted the main-sym-conflict-4 branchJuly 17, 2025 18:18
@llvm-ci
Copy link
Collaborator

LLVM Buildbot has detected a new failure on builderppc64le-flang-rhel-clang running onppc64le-flang-rhel-test while buildingflang at step 6 "test-build-unified-tree-check-flang".

Full details are available at:https://lab.llvm.org/buildbot/#/builders/157/builds/34156

Here is the relevant piece of the build log for the reference
Step 6 (test-build-unified-tree-check-flang) failure: test (failure)******************** TEST 'Flang :: Semantics/PowerPC/ppc-vector-types01.f90' FAILED ********************Exit Code: 1Command Output (stderr):--/home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/build/bin/flang -fc1 -fdebug-unparse /home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/llvm-project/flang/test/Semantics/PowerPC/ppc-vector-types01.f90 | /home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/build/bin/FileCheck /home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/llvm-project/flang/test/Semantics/PowerPC/ppc-vector-types01.f90 # RUN: at line 1+ /home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/build/bin/flang -fc1 -fdebug-unparse /home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/llvm-project/flang/test/Semantics/PowerPC/ppc-vector-types01.f90+ /home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/build/bin/FileCheck /home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/llvm-project/flang/test/Semantics/PowerPC/ppc-vector-types01.f90/home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/llvm-project/flang/test/Semantics/PowerPC/ppc-vector-types01.f90:4:17: error: CHECK-LABEL: expected string not found in input ! CHECK-LABEL: PROGRAM ppc_vec_unit                ^<stdin>:1:1: note: scanning from herePROGRAM PPC_VEC_UNIT^Input file: <stdin>Check file: /home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/llvm-project/flang/test/Semantics/PowerPC/ppc-vector-types01.f90-dump-input=help explains the following input dump.Input was:<<<<<<         1: PROGRAM PPC_VEC_UNIT label:4     X~~~~~~~~~~~~~~~~~~~~ error: no match found         2:  IMPLICIT NONE label:4     ~~~~~~~~~~~~~~~         3:  VECTOR(INTEGER(KIND=4_4)) :: vi1, vi2 label:4     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~         4:  VECTOR(REAL(KIND=8_4)) :: vr1, vr2 label:4     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~         5:  VECTOR(UNSIGNED(KIND=2_4)) :: vu1, vu2 label:4     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~         6:  __VECTOR_PAIR :: vp1, vp2 label:4     ~~~~~~~~~~~~~~~~~~~~~~~~~~~         .         .         .>>>>>>--********************

@eugeneepshteyn
Copy link
ContributorAuthor

eugeneepshteyn commentedJul 18, 2025•
edited
Loading

LLVM Buildbot has detected a new failure on builderppc64le-flang-rhel-clang running onppc64le-flang-rhel-test while buildingflang at step 6 "test-build-unified-tree-check-flang".

Full details are available at:https://lab.llvm.org/buildbot/#/builders/157/builds/34156

Here is the relevant piece of the build log for the reference

Test modifications:#149508

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@klauslerklauslerklausler approved these changes

@clementvalclementvalAwaiting requested review from clementval

@akuhlensakuhlensAwaiting requested review from akuhlens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@eugeneepshteyn@llvm-ci@klausler
[8]ページ先頭
©2009-2025 Movatter.jp