[CGData][GMF] Skip merging unnamed functions#148995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

kyulee-com merged 1 commit intollvm:mainfromkyulee-com:fix-unnamed

Jul 16, 2025

Merged

[CGData][GMF] Skip merging unnamed functions#148995

kyulee-com merged 1 commit intollvm:mainfromkyulee-com:fix-unnamed

Jul 16, 2025

+36 −0

Conversation

Copy link

Contributor

kyulee-com commentedJul 15, 2025•
edited
Loading

Skip merging unnamed functions to fix an assertion issue, since unnamed functions would otherwise receive the same merged name --https://github.com/llvm/llvm-project/blob/main/llvm/lib/CodeGen/GlobalMergeFunctions.cpp#L191

[CGData][GMF] Skip merging unnamed functions

b7f03d2

kyulee-com requested review fromdrodriguez,ellishg andDataCorrupted

July 15, 2025 23:55

llvmbot added backend:AArch64 llvm:codegen labels

Jul 15, 2025

Copy link

Member

llvmbot commentedJul 15, 2025

@llvm/pr-subscribers-backend-aarch64

Author: Kyungwoo Lee (kyulee-com)

Changes

Skip merging unnamed functions for simplicity.

Full diff:https://github.com/llvm/llvm-project/pull/148995.diff

2 Files Affected:

(modified) llvm/lib/CodeGen/GlobalMergeFunctions.cpp (+4)
(added) llvm/test/CodeGen/AArch64/cgdata-no-merge-unnamed.ll (+32)

diff --git a/llvm/lib/CodeGen/GlobalMergeFunctions.cpp b/llvm/lib/CodeGen/GlobalMergeFunctions.cppindex 92ecfadf97c99..73f11c1345daf 100644--- a/llvm/lib/CodeGen/GlobalMergeFunctions.cpp+++ b/llvm/lib/CodeGen/GlobalMergeFunctions.cpp@@ -95,6 +95,10 @@ bool isEligibleFunction(Function *F) {   if (F->getCallingConv() == CallingConv::SwiftTail)     return false;+  // Unnamed functions are skipped for simplicity.+  if (!F->hasName())+    return false;+   // If function contains callsites with musttail, if we merge   // it, the merged function will have the musttail callsite, but   // the number of parameters can change, thus the parameter countdiff --git a/llvm/test/CodeGen/AArch64/cgdata-no-merge-unnamed.ll b/llvm/test/CodeGen/AArch64/cgdata-no-merge-unnamed.llnew file mode 100644index 0000000000000..9986af7eb231c--- /dev/null+++ b/llvm/test/CodeGen/AArch64/cgdata-no-merge-unnamed.ll@@ -0,0 +1,32 @@+; This test checks if two similar functions, @0 and @1, are not merged as they are unnamed.++; RUN: opt -mtriple=arm64-apple-darwin -S --passes=global-merge-func %s | FileCheck %s+; RUN: llc -mtriple=arm64-apple-darwin -enable-global-merge-func=true < %s | FileCheck %s++; CHECK-NOT: .Tgm++@g = external local_unnamed_addr global [0 x i32], align 4+@g1 = external global i32, align 4+@g2 = external global i32, align 4++define i32 @0(i32 %a) {+entry:+  %idxprom = sext i32 %a to i64+  %arrayidx = getelementptr inbounds [0 x i32], [0 x i32]* @g, i64 0, i64 %idxprom+  %0 = load i32, i32* %arrayidx, align 4+  %1 = load volatile i32, i32* @g1, align 4+  %mul = mul nsw i32 %1, %0+  %add = add nsw i32 %mul, 1+  ret i32 %add+}++define i32 @1(i32 %a) {+entry:+  %idxprom = sext i32 %a to i64+  %arrayidx = getelementptr inbounds [0 x i32], [0 x i32]* @g, i64 0, i64 %idxprom+  %0 = load i32, i32* %arrayidx, align 4+  %1 = load volatile i32, i32* @g2, align 4+  %mul = mul nsw i32 %1, %0+  %add = add nsw i32 %mul, 1+  ret i32 %add+}