- Notifications
You must be signed in to change notification settings - Fork14.5k
[flang] Catch bad members of BIND(C) COMMON block#148971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
+44 −11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
@llvm/pr-subscribers-flang-semantics Author: Peter Klausler (klausler) ChangesVariables that can't be BIND(C), like pointers, can't be in a BIND(C) common block, either. Fixes#148922. Full diff:https://github.com/llvm/llvm-project/pull/148971.diff 2 Files Affected:
diff --git a/flang/lib/Semantics/check-declarations.cpp b/flang/lib/Semantics/check-declarations.cppindex f9d64485f1407..04fedcee20f12 100644--- a/flang/lib/Semantics/check-declarations.cpp+++ b/flang/lib/Semantics/check-declarations.cpp@@ -151,8 +151,8 @@ class CheckHelper { void CheckProcedureAssemblyName(const Symbol &symbol); void CheckExplicitSave(const Symbol &); parser::Messages WhyNotInteroperableDerivedType(const Symbol &);- parser::Messages WhyNotInteroperableObject(- const Symbol &, bool allowNonInteroperableType = false);+ parser::Messages WhyNotInteroperableObject(const Symbol &,+ bool allowNonInteroperableType = false, bool forCommonBlock = false); parser::Messages WhyNotInteroperableFunctionResult(const Symbol &); parser::Messages WhyNotInteroperableProcedure(const Symbol &, bool isError); void CheckBindC(const Symbol &);@@ -519,11 +519,28 @@ void CheckHelper::Check(const Symbol &symbol) { } void CheckHelper::CheckCommonBlock(const Symbol &symbol) {+ auto restorer{messages_.SetLocation(symbol.name())}; CheckGlobalName(symbol); if (symbol.attrs().test(Attr::BIND_C)) { CheckBindC(symbol);+ for (auto ref : symbol.get<CommonBlockDetails>().objects()) {+ if (ref->has<ObjectEntityDetails>()) {+ if (auto msgs{WhyNotInteroperableObject(*ref,+ /*allowInteroperableType=*/false, /*forCommonBlock=*/true)};+ !msgs.empty()) {+ if (auto *msg{messages_.Say(symbol.name(),+ "'%s' may not be a member of BIND(C) COMMON block /%s/"_err_en_US,+ ref->name(), symbol.name())}) {+ for (parser::Message &reason : msgs.messages()) {+ reason.set_severity(parser::Severity::Because);+ msg->Attach(std::move(reason));+ }+ }+ }+ }+ } }- for (MutableSymbolRef ref : symbol.get<CommonBlockDetails>().objects()) {+ for (auto ref : symbol.get<CommonBlockDetails>().objects()) { if (ref->test(Symbol::Flag::CrayPointee)) { messages_.Say(ref->name(), "Cray pointee '%s' may not be a member of a COMMON block"_err_en_US,@@ -3154,14 +3171,16 @@ parser::Messages CheckHelper::WhyNotInteroperableDerivedType( } parser::Messages CheckHelper::WhyNotInteroperableObject(- const Symbol &symbol, bool allowNonInteroperableType) {+ const Symbol &symbol, bool allowNonInteroperableType, bool forCommonBlock) { parser::Messages msgs;- if (examinedByWhyNotInteroperable_.find(symbol) !=- examinedByWhyNotInteroperable_.end()) {- return msgs;+ if (!forCommonBlock) {+ if (examinedByWhyNotInteroperable_.find(symbol) !=+ examinedByWhyNotInteroperable_.end()) {+ return msgs;+ }+ examinedByWhyNotInteroperable_.insert(symbol); } bool isExplicitBindC{symbol.attrs().test(Attr::BIND_C)};- examinedByWhyNotInteroperable_.insert(symbol); CHECK(symbol.has<ObjectEntityDetails>()); if (isExplicitBindC && !symbol.owner().IsModule()) { msgs.Say(symbol.name(),@@ -3338,8 +3357,8 @@ parser::Messages CheckHelper::WhyNotInteroperableProcedure( // on the C side by either a cdesc_t * or a void *. F'2023 18.3.7 (5) bool allowNonInteroperableType{!dummy->attrs().test(Attr::VALUE) && (IsDescriptor(*dummy) || IsAssumedType(*dummy))};- dummyMsgs =- WhyNotInteroperableObject(*dummy, allowNonInteroperableType);+ dummyMsgs = WhyNotInteroperableObject(+ *dummy, allowNonInteroperableType, /*forCommonBlock=*/false); } else { CheckBindC(*dummy); }diff --git a/flang/test/Semantics/bind-c18.f90 b/flang/test/Semantics/bind-c18.f90new file mode 100644index 0000000000000..98a90796c514d--- /dev/null+++ b/flang/test/Semantics/bind-c18.f90@@ -0,0 +1,7 @@+! RUN: %python %S/test_errors.py %s %flang_fc1+bind(c) :: /blk/+!ERROR: 'x' may not be a member of BIND(C) COMMON block /blk/+!BECAUSE: A scalar interoperable variable may not be ALLOCATABLE or POINTER+common /blk/ x+integer, pointer :: x+end |
Variables that can't be BIND(C), like pointers, can't bein a BIND(C) common block, either.Fixesllvm#148922.
DanielCChen approved these changesJul 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM.
Thanks!
3de11b7 intollvm:main 9 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Variables that can't be BIND(C), like pointers, can't be in a BIND(C) common block, either.
Fixes#148922.