- Notifications
You must be signed in to change notification settings - Fork14.5k
[llvm-exegesis] fix test when building LLVM for WoA. NFC#148968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
If building with LLVM_DEFAULT_TARGET_TRIPLE=arm-none-linux-gnueabi onWoS, this test fails, so force it to use aarch64 with -mtriple.
@llvm/pr-subscribers-tools-llvm-exegesis Author: Stephen Long (steplong) ChangesIf building with LLVM_DEFAULT_TARGET_TRIPLE=arm-none-linux-gnueabi on WoS, this test fails, so force it to use aarch64 with -mtriple. Full diff:https://github.com/llvm/llvm-project/pull/148968.diff 1 Files Affected:
diff --git a/llvm/test/tools/llvm-exegesis/AArch64/setReg_init_check.s b/llvm/test/tools/llvm-exegesis/AArch64/setReg_init_check.sindex a4350fc6dc2cb..3ef664f899551 100644--- a/llvm/test/tools/llvm-exegesis/AArch64/setReg_init_check.s+++ b/llvm/test/tools/llvm-exegesis/AArch64/setReg_init_check.s@@ -3,7 +3,7 @@ REQUIRES: aarch64-registered-target ## PPR Register Class Initialization Testcase ## Ideally, we should use PTRUE_{B/H/S/D} instead of FADDV_VPZ_D for an isolated test case; ## However, exegesis does not yet support PTRUE_{B/H/S/D}.-RUN: llvm-exegesis -mcpu=neoverse-v2 -mode=latency --dump-object-to-disk=%d --opcode-name=FADDV_VPZ_D --benchmark-phase=assemble-measured-code 2>&1+RUN: llvm-exegesis -mtriple=aarch64 -mcpu=neoverse-v2 -mode=latency --dump-object-to-disk=%d --opcode-name=FADDV_VPZ_D --benchmark-phase=assemble-measured-code 2>&1 RUN: llvm-objdump -d %d > %t.s RUN: FileCheck %s --check-prefix=PPR_ASM < %t.s PPR_ASM: <foo>:@@ -14,7 +14,7 @@ PPR_ASM-NEXT: faddv d{{[0-9]+}}, p{{[0-9]+}}, z{{[0-9]+}} ## ZPR Register Class Initialization Testcase ## Ideally, we should use DUP_ZI_{B/H/S/D} instead of FADDV_VPZ_D for an isolated test case; ## However, exegesis does not yet support DUP_ZI_{B/H/S/D}.-RUN: llvm-exegesis -mcpu=neoverse-v2 -mode=latency --dump-object-to-disk=%d --opcode-name=FADDV_VPZ_D --benchmark-phase=assemble-measured-code 2>&1+RUN: llvm-exegesis -mtriple=aarch64 -mcpu=neoverse-v2 -mode=latency --dump-object-to-disk=%d --opcode-name=FADDV_VPZ_D --benchmark-phase=assemble-measured-code 2>&1 RUN: llvm-objdump -d %d > %t.s RUN: FileCheck %s --check-prefix=ZPR_ASM < %t.s ZPR_ASM: <foo>:@@ -23,7 +23,7 @@ ZPR_ASM-NEXT: mov z{{[0-9]+}}.d, #0x0 ZPR_ASM-NEXT: faddv d{{[0-9]+}}, p{{[0-9]+}}, z{{[0-9]+}} ## FPR128 Register Class Initialization Testcase-RUN: llvm-exegesis -mcpu=neoverse-v2 -mode=latency --dump-object-to-disk=%d --opcode-name=ADDVv16i8v --benchmark-phase=assemble-measured-code 2>&1+RUN: llvm-exegesis -mtriple=aarch64 -mcpu=neoverse-v2 -mode=latency --dump-object-to-disk=%d --opcode-name=ADDVv16i8v --benchmark-phase=assemble-measured-code 2>&1 RUN: llvm-objdump -d %d > %t.s RUN: FileCheck %s --check-prefix=FPR128-ASM < %t.s FPR128-ASM: <foo>:@@ -31,7 +31,7 @@ FPR128-ASM: movi v{{[0-9]+}}.2d, #0000000000000000 FPR128-ASM-NEXT: addv b{{[0-9]+}}, v{{[0-9]+}}.16b ## FPR64 Register Class Initialization Testcase-RUN: llvm-exegesis -mcpu=neoverse-v2 -mode=latency --dump-object-to-disk=%d --opcode-name=ADDVv4i16v --benchmark-phase=assemble-measured-code 2>&1+RUN: llvm-exegesis -mtriple=aarch64 -mcpu=neoverse-v2 -mode=latency --dump-object-to-disk=%d --opcode-name=ADDVv4i16v --benchmark-phase=assemble-measured-code 2>&1 RUN: llvm-objdump -d %d > %t.s RUN: FileCheck %s --check-prefix=FPR64-ASM < %t.s FPR64-ASM: <foo>:@@ -39,7 +39,7 @@ FPR64-ASM: movi d{{[0-9]+}}, #0000000000000000 FPR64-ASM-NEXT: addv h{{[0-9]+}}, v{{[0-9]+}}.4h ## FPR32 Register Class Initialization Testcase-RUN: llvm-exegesis -mcpu=neoverse-v2 -mode=latency --dump-object-to-disk=%d --opcode-name=FABSSr --benchmark-phase=assemble-measured-code 2>&1+RUN: llvm-exegesis -mtriple=aarch64 -mcpu=neoverse-v2 -mode=latency --dump-object-to-disk=%d --opcode-name=FABSSr --benchmark-phase=assemble-measured-code 2>&1 RUN: llvm-objdump -d %d > %t.s RUN: FileCheck %s --check-prefix=FPR32-ASM < %t.s FPR32-ASM: <foo>:@@ -48,7 +48,7 @@ FPR32-ASM-NEXT: fabs s{{[0-9]+}}, s{{[0-9]+}} ## FPR16 Register Class Initialization Testcase-RUN: llvm-exegesis -mcpu=neoverse-v2 -mode=latency --dump-object-to-disk=%d --opcode-name=FABSHr --benchmark-phase=assemble-measured-code 2>&1+RUN: llvm-exegesis -mtriple=aarch64 -mcpu=neoverse-v2 -mode=latency --dump-object-to-disk=%d --opcode-name=FABSHr --benchmark-phase=assemble-measured-code 2>&1 RUN: llvm-objdump -d %d > %t.s RUN: FileCheck %s --check-prefix=FPR16-ASM < %t.s FPR16-ASM: <foo>:@@ -56,7 +56,7 @@ FPR16-ASM: movi d{{[0-9]+}}, #0000000000000000 FPR16-ASM-NEXT: fabs h{{[0-9]+}}, h{{[0-9]+}} ## FPR8 Register Class Initialization Testcase-RUN: llvm-exegesis -mcpu=neoverse-v2 -mode=latency --dump-object-to-disk=%d --opcode-name=SQABSv1i8 --benchmark-phase=assemble-measured-code 2>&1+RUN: llvm-exegesis -mtriple=aarch64 -mcpu=neoverse-v2 -mode=latency --dump-object-to-disk=%d --opcode-name=SQABSv1i8 --benchmark-phase=assemble-measured-code 2>&1 RUN: llvm-objdump -d %d > %t.s RUN: FileCheck %s --check-prefix=FPR8-ASM < %t.s FPR8-ASM: <foo>:@@ -65,7 +65,7 @@ FPR8-ASM-NEXT: sqabs b{{[0-9]+}}, b{{[0-9]+}} ## FPCR Register Class Initialization Testcase-RUN: llvm-exegesis -mcpu=neoverse-v2 -mode=latency --dump-object-to-disk=%d --opcode-name=BFCVT --benchmark-phase=assemble-measured-code 2>&1+RUN: llvm-exegesis -mtriple=aarch64 -mcpu=neoverse-v2 -mode=latency --dump-object-to-disk=%d --opcode-name=BFCVT --benchmark-phase=assemble-measured-code 2>&1 RUN: llvm-objdump -d %d > %t.s RUN: FileCheck %s --check-prefix=FPCR-ASM < %t.s FPCR-ASM: <foo>: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What is WoS?
Oh whoops, I meant WoA, Windows on ARM |
boomanaiden154 approved these changesJul 16, 2025
53355ab intollvm:main 11 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
If building with LLVM_DEFAULT_TARGET_TRIPLE=arm-none-linux-gnueabi on WoA (Windows on ARM), this test fails, so force it to use aarch64 with -mtriple.