TableGen: Fixed the string table definitions visibility.#148946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

vzakhari merged 2 commits intollvm:mainfromvzakhari:buildbots_after_148839

Jul 15, 2025

Merged

TableGen: Fixed the string table definitions visibility.#148946

vzakhari merged 2 commits intollvm:mainfromvzakhari:buildbots_after_148839

Jul 15, 2025

+4 −3

Conversation

Copy link

Contributor

vzakhari commentedJul 15, 2025

This fixes the buildbots issues reported in#148839.

TableGen: Fixed the string table definitions visibility.

01fc35a

This fixes the buildbots issues reported inllvm#148839.

vzakhari requested review fromarsenm,nikic,dyung andjurahul

July 15, 2025 19:54

llvmbot added the tablegen label

Jul 15, 2025

Copy link

Member

llvmbot commentedJul 15, 2025

@llvm/pr-subscribers-tablegen

Author: Slava Zakharin (vzakhari)

Changes

This fixes the buildbots issues reported in #148839.

Full diff:https://github.com/llvm/llvm-project/pull/148946.diff

1 Files Affected:

(modified) llvm/lib/TableGen/StringToOffsetTable.cpp (+3-2)

diff --git a/llvm/lib/TableGen/StringToOffsetTable.cpp b/llvm/lib/TableGen/StringToOffsetTable.cppindex d6d2c2590389a..41f82caa12f82 100644--- a/llvm/lib/TableGen/StringToOffsetTable.cpp+++ b/llvm/lib/TableGen/StringToOffsetTable.cpp@@ -83,10 +83,11 @@ void StringToOffsetTable::EmitStringTableDef(raw_ostream &OS, #pragma GCC diagnostic pop #endif-{1}constexpr llvm::StringTable+{1} llvm::StringTable {2}{0} = {0}Storage; )",-                Name, ClassPrefix.empty() ? "static " : "", ClassPrefix);+                Name, ClassPrefix.empty() ? "static constexpr" : "const",+                ClassPrefix); }  void StringToOffsetTable::EmitString(raw_ostream &O) const {