- Notifications
You must be signed in to change notification settings - Fork14.5k
[NFC][SemaHLSL] Fix typo causing float to double conversion#148941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
- it was noted, here, that by accidently not specifying this explicitlyas a float it will cause a build warning on MSVC- this commit resolves this by explicitly specifying it as a float
@llvm/pr-subscribers-clang Author: Finn Plummer (inbelic) Changes
Full diff:https://github.com/llvm/llvm-project/pull/148941.diff 1 Files Affected:
diff --git a/clang/lib/Sema/SemaHLSL.cpp b/clang/lib/Sema/SemaHLSL.cppindex 4875c25c76988..9276554bebf9d 100644--- a/clang/lib/Sema/SemaHLSL.cpp+++ b/clang/lib/Sema/SemaHLSL.cpp@@ -1150,7 +1150,7 @@ bool SemaHLSL::handleRootSignatureElements( if (!llvm::hlsl::rootsig::verifyMaxAnisotropy(Sampler->MaxAnisotropy)) ReportError(Loc, 0, 16); if (!llvm::hlsl::rootsig::verifyMipLODBias(Sampler->MipLODBias))- ReportFloatError(Loc, -16.f, 15.99);+ ReportFloatError(Loc, -16.f, 15.99f); } else if (const auto *Clause = std::get_if<llvm::hlsl::rootsig::DescriptorTableClause>( &Elem)) { |
@llvm/pr-subscribers-hlsl Author: Finn Plummer (inbelic) Changes
Full diff:https://github.com/llvm/llvm-project/pull/148941.diff 1 Files Affected:
diff --git a/clang/lib/Sema/SemaHLSL.cpp b/clang/lib/Sema/SemaHLSL.cppindex 4875c25c76988..9276554bebf9d 100644--- a/clang/lib/Sema/SemaHLSL.cpp+++ b/clang/lib/Sema/SemaHLSL.cpp@@ -1150,7 +1150,7 @@ bool SemaHLSL::handleRootSignatureElements( if (!llvm::hlsl::rootsig::verifyMaxAnisotropy(Sampler->MaxAnisotropy)) ReportError(Loc, 0, 16); if (!llvm::hlsl::rootsig::verifyMipLODBias(Sampler->MipLODBias))- ReportFloatError(Loc, -16.f, 15.99);+ ReportFloatError(Loc, -16.f, 15.99f); } else if (const auto *Clause = std::get_if<llvm::hlsl::rootsig::DescriptorTableClause>( &Elem)) { |
8d61073 intollvm:mainUh oh!
There was an error while loading.Please reload this page.
it was noted,here, that by accidently not specifying this explicitly as a float it will cause a build warning on MSVC
this commit resolves this by explicitly specifying it as a float