- Notifications
You must be signed in to change notification settings - Fork14.5k
[NFC][IR2Vec] Fix warnings on MSVC compilation#148911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
@llvm/pr-subscribers-llvm-analysis Author: S. VenkataKeerthy (svkeerthy) ChangesFull diff:https://github.com/llvm/llvm-project/pull/148911.diff 1 Files Affected:
diff --git a/llvm/lib/Analysis/IR2Vec.cpp b/llvm/lib/Analysis/IR2Vec.cppindex cfe0c566e2adc..898bf5b202feb 100644--- a/llvm/lib/Analysis/IR2Vec.cpp+++ b/llvm/lib/Analysis/IR2Vec.cpp@@ -304,10 +304,11 @@ Vocabulary::VocabVector Vocabulary::createDummyVocabForTest(unsigned Dim) { float DummyVal = 0.1f; // Create a dummy vocabulary with entries for all opcodes, types, and // operand- for (unsigned _ : seq(0u, Vocabulary::MaxOpcodes + Vocabulary::MaxTypeIDs +- Vocabulary::MaxOperandKinds)) {+ for ([[maybe_unused]] unsigned _ :+ seq(0u, Vocabulary::MaxOpcodes + Vocabulary::MaxTypeIDs ++ Vocabulary::MaxOperandKinds)) { DummyVocab.push_back(Embedding(Dim, DummyVal));- DummyVal += 0.1;+ DummyVal += 0.1f; } return DummyVocab; } |
@llvm/pr-subscribers-mlgo Author: S. VenkataKeerthy (svkeerthy) ChangesFull diff:https://github.com/llvm/llvm-project/pull/148911.diff 1 Files Affected:
diff --git a/llvm/lib/Analysis/IR2Vec.cpp b/llvm/lib/Analysis/IR2Vec.cppindex cfe0c566e2adc..898bf5b202feb 100644--- a/llvm/lib/Analysis/IR2Vec.cpp+++ b/llvm/lib/Analysis/IR2Vec.cpp@@ -304,10 +304,11 @@ Vocabulary::VocabVector Vocabulary::createDummyVocabForTest(unsigned Dim) { float DummyVal = 0.1f; // Create a dummy vocabulary with entries for all opcodes, types, and // operand- for (unsigned _ : seq(0u, Vocabulary::MaxOpcodes + Vocabulary::MaxTypeIDs +- Vocabulary::MaxOperandKinds)) {+ for ([[maybe_unused]] unsigned _ :+ seq(0u, Vocabulary::MaxOpcodes + Vocabulary::MaxTypeIDs ++ Vocabulary::MaxOperandKinds)) { DummyVocab.push_back(Embedding(Dim, DummyVal));- DummyVal += 0.1;+ DummyVal += 0.1f; } return DummyVocab; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM!
fad0fbc intomainUh oh!
There was an error while loading.Please reload this page.
No description provided.