- Notifications
You must be signed in to change notification settings - Fork14.5k
[DTLTO][TEST] Fix Clang driver test failing on some build bots#148908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
Not all builds name the compiler executable `clang`. For example,the Fuchsia build bots use `llvm` as the executable name, as theycombine everything together in a busybot-style binary.Update the Clang driver test to simply check that a non-empty pathis provided for the `--thinlto-remote-compiler` argument, ratherthan hardcoding the executable name. The cross-project test willverify that the path is valid later.Shouldfixllvm#147265.
llvmbot commentedJul 15, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@llvm/pr-subscribers-clang-driver @llvm/pr-subscribers-clang Author: bd1976bris (bd1976bris) ChangesNot all builds name the compiler executable Update the Clang driver test to simply check that a non-empty path is provided for the Should fix #147265. Full diff:https://github.com/llvm/llvm-project/pull/148908.diff 1 Files Affected:
diff --git a/clang/test/Driver/DTLTO/dtlto.c b/clang/test/Driver/DTLTO/dtlto.cindex d72e487e706b2..96795d9a4e6a4 100644--- a/clang/test/Driver/DTLTO/dtlto.c+++ b/clang/test/Driver/DTLTO/dtlto.c@@ -10,7 +10,7 @@ // FORWARD: ld.lld // FORWARD-SAME: "--thinlto-distributor=d.exe"-// FORWARD-SAME: "--thinlto-remote-compiler={{.*}}clang{{[^\"]*}}"+// FORWARD-SAME: "--thinlto-remote-compiler={{[^"]+}}" // FORWARD-SAME: "--thinlto-distributor-arg=a1" // FORWARD-SAME: "--thinlto-distributor-arg=a2" // FORWARD-SAME: "--thinlto-distributor-arg=a3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM.
edfec9c intollvm:mainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Not all builds name the compiler executable
clang. For example, the Fuchsia build bots usellvmas their single toolchain executable name, as they combine everything together in a busybox-style binary.Update the Clang driver test to simply check that a non-empty path is provided for the
--thinlto-remote-compilerargument, rather than hardcoding the executable name. The cross-project test will verify that the path is valid later.Shouldfix#147265.