- Notifications
You must be signed in to change notification settings - Fork14.5k
[libc++] Remove unused _LIBCPP_HAS_NO_STD_MODULES macro from __config_site#148902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
ldionne merged 1 commit intollvm:mainfromldionne:review/remove-outdated-modules-macro-from-config-siteJul 18, 2025
Merged
[libc++] Remove unused _LIBCPP_HAS_NO_STD_MODULES macro from __config_site#148902
ldionne merged 1 commit intollvm:mainfromldionne:review/remove-outdated-modules-macro-from-config-siteJul 18, 2025
+0 −2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…_siteSince1d6b613, that macro isn't used anywhere anymore.
@llvm/pr-subscribers-libcxx Author: Louis Dionne (ldionne) ChangesSince1d6b613, that macro isn't used anywhere anymore. Full diff:https://github.com/llvm/llvm-project/pull/148902.diff 2 Files Affected:
diff --git a/libcxx/include/__config_site.in b/libcxx/include/__config_site.inindex fc01aaf2d8746..b68c0c8258366 100644--- a/libcxx/include/__config_site.in+++ b/libcxx/include/__config_site.in@@ -30,7 +30,6 @@ #cmakedefine01 _LIBCPP_HAS_LOCALIZATION #cmakedefine01 _LIBCPP_HAS_UNICODE #cmakedefine01 _LIBCPP_HAS_WIDE_CHARACTERS-#cmakedefine _LIBCPP_HAS_NO_STD_MODULES #cmakedefine01 _LIBCPP_HAS_TIME_ZONE_DATABASE #cmakedefine01 _LIBCPP_INSTRUMENTED_WITH_ASANdiff --git a/llvm/utils/gn/secondary/libcxx/include/BUILD.gn b/llvm/utils/gn/secondary/libcxx/include/BUILD.gnindex 6051674a790e8..f6473c672a050 100644--- a/llvm/utils/gn/secondary/libcxx/include/BUILD.gn+++ b/llvm/utils/gn/secondary/libcxx/include/BUILD.gn@@ -35,7 +35,6 @@ if (current_toolchain == default_toolchain) { "_LIBCPP_HAS_LOCALIZATION=1", "_LIBCPP_HAS_UNICODE=1", "_LIBCPP_HAS_WIDE_CHARACTERS=1",- "_LIBCPP_HAS_NO_STD_MODULES=", "_LIBCPP_HAS_TERMINAL=1", "_LIBCPP_INSTRUMENTED_WITH_ASAN=", "_LIBCPP_ABI_DEFINES=", |
0e40695 intollvm:main 79 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since1d6b613, that macro isn't used anywhere anymore.