Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[clang-tools-extra][NFC] Fix link to code review in README.txt#148384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vbvictor merged 2 commits intollvm:mainfromvbvictor:fix-reviews-link
Jul 17, 2025

Conversation

vbvictor
Copy link
Contributor

I'm not sure if we need to add label inside link or not, butlists.llvm.org seems outdated for sure, WDYT?

@llvmbot
Copy link
Member

@llvm/pr-subscribers-clang-tools-extra

Author: Baranov Victor (vbvictor)

Changes

I'm not sure if we need to add label inside link or not, butlists.llvm.org seems outdated for sure, WDYT?

Full diff:https://github.com/llvm/llvm-project/pull/148384.diff

1 Files Affected:

  • (modified) clang-tools-extra/README.txt (+2-3)
diff --git a/clang-tools-extra/README.txt b/clang-tools-extra/README.txtindex 6891e4078997f..7a0614facd835 100644--- a/clang-tools-extra/README.txt+++ b/clang-tools-extra/README.txt@@ -11,9 +11,8 @@ All discussion regarding Clang, Clang-based tools, and code in this repository should be held using the standard Clang forum:   https://discourse.llvm.org/c/clang-Code review for this tree should take place on the standard Clang patch and-commit lists:-  http://lists.llvm.org/mailman/listinfo/cfe-commits+Code review for this tree should take place on Github:+  https://github.com/llvm/llvm-project/pulls?q=label%3Aclang-tools-extra  If you find a bug in these tools, please file it in the LLVM bug tracker:   https://github.com/llvm/llvm-project/issues/

@EugeneZelenko
Copy link
Contributor

There are dedicated Discourse topics for Clangd and Clang-Tidy. May be they should be mentioned explicitly?

vbvictor reacted with thumbs up emoji

@vbvictor
Copy link
ContributorAuthor

vbvictor commentedJul 12, 2025•
edited
Loading

There are dedicated Discourse topics for Clangd and Clang-Tidy. May be they should be mentioned explicitly?

Added links to them as a list, do you think we need a new entry for each of the link?
IMO from reading the link name, user can understand where it points.

@EugeneZelenko
Copy link
Contributor

There are dedicated Discourse topics for Clangd and Clang-Tidy. May be they should be mentioned explicitly?

Added links to them as a list, do you think we need a new entry for each of the link? IMO from reading the link name, user can understand where it points.

Yes, links are in comprehensible format.

Copy link
Contributor

@EugeneZelenkoEugeneZelenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks OK for me, but please wait for other reviewers, I may miss something :-)

@vbvictorvbvictor changed the title[clang-tools-extra][NFC] fix link to code review in README.txt[clang-tools-extra][NFC] Fix link to code review in README.txtJul 12, 2025
@vbvictorvbvictor merged commit149aa76 intollvm:mainJul 17, 2025
9 checks passed
@vbvictorvbvictor deleted the fix-reviews-link branchJuly 17, 2025 15:38
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@carlosgalvezpcarlosgalvezpcarlosgalvezp approved these changes

@EugeneZelenkoEugeneZelenkoEugeneZelenko approved these changes

@AaronBallmanAaronBallmanAwaiting requested review from AaronBallman

@5chmidti5chmidtiAwaiting requested review from 5chmidti

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@vbvictor@llvmbot@EugeneZelenko@carlosgalvezp
[8]ページ先頭
©2009-2025 Movatter.jp