- Notifications
You must be signed in to change notification settings - Fork14.5k
[libc++] Simplify the implementation of __libcpp_{,de}allocate#147989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
philnik777 merged 1 commit intollvm:mainfromphilnik777:simplify_libcpp_allocate_deallocateJul 15, 2025
Merged
[libc++] Simplify the implementation of __libcpp_{,de}allocate#147989
philnik777 merged 1 commit intollvm:mainfromphilnik777:simplify_libcpp_allocate_deallocateJul 15, 2025
+20 −51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
GCC 15 also supports `__buitin_operator_{new,delete}` now, so the `#else` cases are dead code. This patch inlines the calls to the wrapper functions and simplifies some surrounding code.8ef1cad tob8ca9feCompare0c3a2fa intollvm:main 76 checks passed
Uh oh!
There was an error while loading.Please reload this page.
@llvm/pr-subscribers-libcxx Author: Nikolas Klauser (philnik777) ChangesGCC 15 also supports Full diff:https://github.com/llvm/llvm-project/pull/147989.diff 1 Files Affected:
diff --git a/libcxx/include/__new/allocate.h b/libcxx/include/__new/allocate.hindex 738fa62af4d61..9bfe19aedb79f 100644--- a/libcxx/include/__new/allocate.h+++ b/libcxx/include/__new/allocate.h@@ -31,37 +31,16 @@ _LIBCPP_CONSTEXPR inline _LIBCPP_HIDE_FROM_ABI bool __is_overaligned_for_new(siz #endif }-template <class... _Args>-_LIBCPP_HIDE_FROM_ABI void* __libcpp_operator_new(_Args... __args) {-#if __has_builtin(__builtin_operator_new) && __has_builtin(__builtin_operator_delete)- return __builtin_operator_new(__args...);-#else- return ::operator new(__args...);-#endif-}--template <class... _Args>-_LIBCPP_HIDE_FROM_ABI void __libcpp_operator_delete(_Args... __args) _NOEXCEPT {-#if __has_builtin(__builtin_operator_new) && __has_builtin(__builtin_operator_delete)- __builtin_operator_delete(__args...);-#else- ::operator delete(__args...);-#endif-}- template <class _Tp> inline _LIBCPP_HIDE_FROM_ABI _LIBCPP_NO_CFI _Tp*-__libcpp_allocate(__element_count __n, size_t __align = _LIBCPP_ALIGNOF(_Tp)) {+__libcpp_allocate(__element_count __n, [[__maybe_unused__]] size_t __align = _LIBCPP_ALIGNOF(_Tp)) { size_t __size = static_cast<size_t>(__n) * sizeof(_Tp); #if _LIBCPP_HAS_ALIGNED_ALLOCATION- if (__is_overaligned_for_new(__align)) {- const align_val_t __align_val = static_cast<align_val_t>(__align);- return static_cast<_Tp*>(std::__libcpp_operator_new(__size, __align_val));- }+ if (__is_overaligned_for_new(__align))+ return static_cast<_Tp*>(__builtin_operator_new(__size, static_cast<align_val_t>(__align))); #endif- (void)__align;- return static_cast<_Tp*>(std::__libcpp_operator_new(__size));+ return static_cast<_Tp*>(__builtin_operator_new(__size)); } #if _LIBCPP_HAS_SIZED_DEALLOCATION@@ -71,39 +50,29 @@ __libcpp_allocate(__element_count __n, size_t __align = _LIBCPP_ALIGNOF(_Tp)) { #endif template <class _Tp>-inline _LIBCPP_HIDE_FROM_ABI void __libcpp_deallocate(- __type_identity_t<_Tp>* __ptr, __element_count __n, size_t __align = _LIBCPP_ALIGNOF(_Tp)) _NOEXCEPT {- size_t __size = static_cast<size_t>(__n) * sizeof(_Tp);- (void)__size;-#if !_LIBCPP_HAS_ALIGNED_ALLOCATION- (void)__align;- return std::__libcpp_operator_delete(__ptr _LIBCPP_ONLY_IF_SIZED_DEALLOCATION(, __size));-#else- if (__is_overaligned_for_new(__align)) {- const align_val_t __align_val = static_cast<align_val_t>(__align);- return std::__libcpp_operator_delete(__ptr _LIBCPP_ONLY_IF_SIZED_DEALLOCATION(, __size), __align_val);- } else {- return std::__libcpp_operator_delete(__ptr _LIBCPP_ONLY_IF_SIZED_DEALLOCATION(, __size));- }+inline _LIBCPP_HIDE_FROM_ABI void+__libcpp_deallocate(__type_identity_t<_Tp>* __ptr,+ __element_count __n,+ [[__maybe_unused__]] size_t __align = _LIBCPP_ALIGNOF(_Tp)) _NOEXCEPT {+ [[__maybe_unused__]] size_t __size = static_cast<size_t>(__n) * sizeof(_Tp);+#if _LIBCPP_HAS_ALIGNED_ALLOCATION+ if (__is_overaligned_for_new(__align))+ return __builtin_operator_delete(+ __ptr _LIBCPP_ONLY_IF_SIZED_DEALLOCATION(, __size), static_cast<align_val_t>(__align)); #endif+ return __builtin_operator_delete(__ptr _LIBCPP_ONLY_IF_SIZED_DEALLOCATION(, __size)); } #undef _LIBCPP_ONLY_IF_SIZED_DEALLOCATION template <class _Tp>-inline _LIBCPP_HIDE_FROM_ABI void-__libcpp_deallocate_unsized(__type_identity_t<_Tp>* __ptr, size_t __align = _LIBCPP_ALIGNOF(_Tp)) _NOEXCEPT {-#if !_LIBCPP_HAS_ALIGNED_ALLOCATION- (void)__align;- return std::__libcpp_operator_delete(__ptr);-#else- if (__is_overaligned_for_new(__align)) {- const align_val_t __align_val = static_cast<align_val_t>(__align);- return std::__libcpp_operator_delete(__ptr, __align_val);- } else {- return std::__libcpp_operator_delete(__ptr);- }+inline _LIBCPP_HIDE_FROM_ABI void __libcpp_deallocate_unsized(+ __type_identity_t<_Tp>* __ptr, [[__maybe_unused__]] size_t __align = _LIBCPP_ALIGNOF(_Tp)) _NOEXCEPT {+#if _LIBCPP_HAS_ALIGNED_ALLOCATION+ if (__is_overaligned_for_new(__align))+ return __builtin_operator_delete(__ptr, static_cast<align_val_t>(__align)); #endif+ return __builtin_operator_delete(__ptr); } _LIBCPP_END_NAMESPACE_STD |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC 15 also supports
__buitin_operator_{new,delete}now, so the#elsecases are dead code. This patch inlines the calls to the wrapper functions and simplifies some surrounding code.