NotificationsYou must be signed in to change notification settings
Fork0
Star0

Commit511449d

committed

Prevent show_session_authorization from crashing when session_authorization

hasn't been set.The only known case where this can happen is when show_session_authorizationis invoked in an autovacuum process, which is possible if an index functioncalls it, as for example in bug #5669 from Andrew Geery. We could perhapstry to return a sensible value, such as the name of the cluster-owningsuperuser; but that seems like much more trouble than the case is worth,and in any case it could create new possible failure modes. Simplyreturning an empty string seems like the most appropriate fix.Back-patch to all supported versions, even those before autovacuum, justin case there's another way to provoke this crash.

1 parent4e2e9f2 commit511449dCopy full SHA for 511449d

File tree

1 file changed

-0

lines changed

src/backend/commands
- variable.c

1 file changed

-0

lines changed

`‎src/backend/commands/variable.c`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -680,6 +680,10 @@ show_session_authorization(void)`
`680`	`680`	`Oidsavedoid;`
`681`	`681`	`char*endptr;`
`682`	`682`
	`683`	`+/* If session_authorization hasn't been set in this process, return "" */`
	`684`	`+if (value==NULL\|\|value[0]=='\0')`
	`685`	`+return"";`
	`686`	`+`
`683`	`687`	`Assert(strspn(value,"x")==NAMEDATALEN&&`
`684`	`688`	`(value[NAMEDATALEN]=='T'\|\|value[NAMEDATALEN]=='F'));`
`685`	`689`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit511449d

File tree

1 file changed

1 file changed

`‎src/backend/commands/variable.c`

0 commit comments