Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add Safari speaker selection support#1635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
fkwp wants to merge3 commits intolivekit:main
base:main
Choose a base branch
Loading
fromfkwp:fkwp/isSafariSpeakerSelectionSupported

Conversation

@fkwp
Copy link

With the next iteration of Apple OSes the Speaker Selection API is supported (https://developer.apple.com/documentation/safari-release-notes/safari-26-release-notes#WebRTC)

This PR adds support for it by:

  • adding aisSafariSpeakerSelectionSupported helper function
  • using that helper function insupportsSetSinkId

fixes#1568 at least for macOS.
In contrast tohttps://webrtc.github.io/samples/src/content/devices/input-output/ this PR does not (yet) fix the issue on iOS26

@changeset-bot
Copy link

⚠️ No Changeset found

Latest commit:cba9b74

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go.If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLAassistant commentedAug 27, 2025•
edited
Loading

CLA assistant check
All committers have signed the CLA.

@fkwpfkwp changed the titleAdd Safari speaker selection supportedAdd Safari speaker selection supportAug 27, 2025
Copy link
Contributor

@lukasIOlukasIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the PR!

I believe the speaker selection API comes with some more caveats (explicit user permission must be granted for output selection if no microphone is acquired yet).

I haven't tested this, but probably needs its own selection path viaMediaDevices.selectAudioOutput ?

return(
(browser?.name==='Safari'&&compareVersions(browser.version,'26')>=0)||
(browser?.os==='iOS'&&!!browser?.osVersion&&compareVersions(browser.osVersion,'26')>=0)||
(browser?.os==='macOS'&&!!browser?.osVersion&&compareVersions(browser.osVersion,'26')>=0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

this check is not connected to checking against Safari, I believe?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@lukasIOlukasIOlukasIO left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for iOS26 Speaker Selection API

3 participants

@fkwp@CLAassistant@lukasIO
[8]ページ先頭
©2009-2025 Movatter.jp