- Notifications
You must be signed in to change notification settings - Fork1.1k
open_posix_testsuite: fix pthread_cond_destroy test error.#1097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
qinyuntan wants to merge1 commit intolinux-test-project:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+37 −30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
According to the description of the pthread_cond_destroy function in glibc 2.32,it is advised to ensure that all threads blocked on the condition variable havebeen successfully awakened before calling this function, otherwise unpredictablesituations may occur.In the glibc 2.32 version, this testcase will hang. Therefore, it is necessaryto ensure that all threads have been successfully awakened before callingpthread_cond_destroy to destroy the condition variable.Signed-off-by: tanqinyun.tqy <tanqinyun.tqy@alibaba-inc.com>
Author
qinyuntan commentedNov 13, 2023
The logs below indicate a failure in the test. ./interfaces/pthread_cond_destroy/pthread_cond_destroy_2-1.run-test[14:25:57]Test starting |
acb468e todc9ba89CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the description of the pthread_cond_destroy function in glibc 2.32, it is advised to ensure that all threads blocked on the condition variable have been successfully awakened before calling this function, otherwise unpredictable situations may occur.
In the glibc 2.32 version, this testcase will hang. Therefore, it is necessary to ensure that all threads have been successfully awakened before calling pthread_cond_destroy to destroy the condition variable.
[ type description here; PLEASE REMOVE THIS LINE AND THE LINES BELOW BEFORE SUBMITTING THIS PULL REQUEST ]