- Notifications
You must be signed in to change notification settings - Fork38
chore(deps): addprost andtonic dependabot groups#455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
this commit adds two groups to the dependabot configuration.this will mean that dependabot updates (a) `tonic` and `tonic-build,`and (b) `prost` and `prost-types`, in lockstep.Signed-off-by: katelyn martin <kate@buoyant.io>
| groups: | ||
| prost: | ||
| patterns: | ||
| - "prost*" | ||
| tonic: | ||
| patterns: | ||
| - "tonic*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Don't these dependencies have to be updatedtogether?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
good question. i noticed these are not maintained as part of the same organization(see repository url's below), and we don't update these together in theproxy at the moment.
i think you're right though.prost generates code based on thetonic interfaces, so.. we should probably do the same thing as thecontrol plane.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
linkerd/linkerd2-proxy#3821 consolidates these groups together. i can do the same here, i'll mark this as a draft in the meantime.
*https://github.com/linkerd/linkerd2/blob/main/.github/dependabot.yml#L81-L86*#3809*linkerd/linkerd2-proxy-api#455 (comment)tonic and prost are interconnected. we should bump them in lockstep.Signed-off-by: katelyn martin <kate@buoyant.io>
*https://github.com/linkerd/linkerd2/blob/main/.github/dependabot.yml#L81-L86*#3809*linkerd/linkerd2-proxy-api#455 (comment)tonic and prost are interconnected. we should bump them in lockstep.Signed-off-by: katelyn martin <kate@buoyant.io>
this commit adds two groups to the dependabot configuration.
this will mean that dependabot updates (a)
tonicandtonic-build,and (b)prostandprost-types, in lockstep.