- Notifications
You must be signed in to change notification settings - Fork245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Version bump#859
Version bump#859
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think that under our current policies, this can only be merged by@waywardmonkeys (or RazrFalcon), as they are the only people with the permissions to publish this.
.github/chart-svg2.svg Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Do these results need to be updated? We have made some changes which I'd naïvely expect to have an impact on the results.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't think so, at least in the past few version bumps also only the version was updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Updating those charts is a mess.
- We have to copy new SVG test files to
resvg-test-suite. - Generate reference PNGs, either via
resvgor Chrome/resvg-test-suite/tools/chrome-svgrender. - We have to tests them agains all other implementations using
resvg-test-suite/tool/vdiff. This would updateresults.csv - Run
resvg-test-suite/stats.py. This would updatesite/images/chart.svgwhich should be copied back toresvg. - Run
resvg-test-suite/stats.py --svg2. This would updatesite/images/chart-svg2.svgwhich should be copied back toresvg.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Generally looks good, missed just one thing.
I see three ways forward for this:
Let me know. |
Having another Linebender member with crates.io access seems like a good idea in general. Also something to keep in mind is that this PR needs the changelog release date change on the day of the merge. |
Should we publish |
Added the link to the bottom and set the merge date as today (assuming it gets merged today). |
Would make sense I guess. 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This looks good now.
However if we want SVG Types published before, would have to wait on merging this.
We were discussing this version bump on the Xi Zulip. Here's my current view on the state:
So I think once the changelog update is merged
|
# Conflicts:#CHANGELOG.md
# Conflicts:#Cargo.lock
No description provided.