Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[POC] Allow clients to specify set TLS specifications per-request#6516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
jrhee17 wants to merge1 commit intoline:main
base:main
Choose a base branch
Loading
fromjrhee17:feat/xds-tls

Conversation

@jrhee17
Copy link
Contributor

Motivation:

Explain why you're making this change and what problem you're trying to solve.

Modifications:

  • List the modifications you've made in detail.

Result:

  • Closes #. (If this resolves the issue.)
  • Describe the consequences that a user will face after this PR is merged.

@coderabbitai
Copy link

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the.coderabbit.yaml file in this repository. To trigger a single review, invoke the@coderabbitai review command.

You can disable this status message by setting thereviews.review_status tofalse in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for usingCodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment@coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actionsbot commentedNov 25, 2025
edited
Loading

@codecov
Copy link

codecovbot commentedNov 25, 2025
edited
Loading

Codecov Report

❌ Patch coverage is80.72855% with164 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.20%. Comparing base (8150425) to head (ea6d7cf).
⚠️ Report is 248 commits behind head on main.

Files with missing linesPatch %Lines
...rmeria/internal/common/util/SignedCertificate.java70.13%36 Missing and 7 partials⚠️
...p/armeria/internal/common/util/SslContextUtil.java80.20%11 Missing and 8 partials⚠️
...ava/com/linecorp/armeria/server/ServerTlsSpec.java70.27%6 Missing and 5 partials⚠️
...om/linecorp/armeria/client/HttpClientDelegate.java79.16%4 Missing and 6 partials⚠️
...a/com/linecorp/armeria/common/AbstractTlsSpec.java80.85%1 Missing and 8 partials⚠️
...nternal/common/util/VerifierBasedTrustManager.java62.50%6 Missing and 3 partials⚠️
...meria/common/InsecureHostsPeerVerifierFactory.java60.00%6 Missing and 2 partials⚠️
.../linecorp/armeria/server/VirtualHostTlsSetter.java86.04%1 Missing and 5 partials⚠️
...ting/junit5/server/SignedCertificateExtension.java75.00%4 Missing and 2 partials⚠️
.../junit5/server/SelfSignedCertificateExtension.java28.57%5 Missing⚠️
... and17 more
Additional details and impacted files
@@             Coverage Diff              @@##               main    #6516      +/-   ##============================================- Coverage     74.46%   74.20%   -0.27%- Complexity    22234    23445    +1211============================================  Files          1963     2110     +147       Lines         82437    87666    +5229       Branches      10764    11500     +736     ============================================+ Hits          61385    65050    +3665- Misses        15918    17126    +1208- Partials       5134     5490     +356

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jrhee17 added a commit that referenced this pull requestNov 28, 2025
…ertificateExtension (#6519)Motivation:This is the first of a series of PRs included by#6516.Currently, our mTLS tests are not realistic in that:- Certificate chains aren't verified- We set TLS configurations to not verify the peer, which means inreality there's no point in using mTLS.For this, I propose that a `SignedCertificate` is introduced. This is acertificate which is signed by another certificate (another`SignedCertificate` or `SelfSignedCertificate`). A JUnit `Extension` hasalso been introduced so users can easily test this behavior.In the process, I found that `SelfSingedCertificateNameType` has a typo,and isn't adding much value. This enum has been removed.Modifications:- Introduced `SignedCertificate`, `SignedCertificateExtension`- `SelfSignedCertificate`, `SelfSignedCertificateExtension` inherits thenewly introduced constructs- Default behavior has been modified so that all generated certificatescan act as a ca.- `SelfSingedCertificateNameType` has been removedResult:- Users can easily create a certificate chain for testing using`SignedCertificateExtension`<!--Visit this URL to learn more about how to write a pull requestdescription:https://armeria.dev/community/developer-guide#how-to-write-pull-request-description-->
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ikhoonikhoonAwaiting requested review from ikhoonikhoon will be requested when the pull request is marked ready for reviewikhoon is a code owner

@minwooxminwooxAwaiting requested review from minwooxminwoox will be requested when the pull request is marked ready for reviewminwoox is a code owner

@trustintrustinAwaiting requested review from trustintrustin will be requested when the pull request is marked ready for reviewtrustin is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jrhee17

[8]ページ先頭

©2009-2025 Movatter.jp