- Notifications
You must be signed in to change notification settings - Fork34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
ex: fix printing of line number when the 's' command is used with the 'c' flag and the number option is set.#115
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…set.The confirmation line already has the appropriate indentation butthe underlined section doesn't line up with the matched text becausethe line it refers to is missing the line number.
It's indeed confusing. Thanks for the change! |
johnsonjh added a commit to johnsonjh/OpenVi that referenced this pull requestFeb 26, 2023
* When using the `s` command with the `c` flag in ex mode, the confirmation line is properly indented to make room for the line number, but the autoprint line doesn't include the line number; the two lines mismatch.* The confirmation line already has the appropriate indentation but the underlined section doesn't line up with the matched text because the line it refers to is missing the line number.* Patch via `nvi2` from millert@* Seelichray/nvi2#115
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, given the line:
issuing the command in ex when the number option is enabled (the output is fine if number is not enabled):
will display:
The confirmation line is indented properly for output when the number option is enabled, but the line above it lacks the expected line number. The output should be, e.g.:
The line number is also missing when the line is reprinted after the confirmation prompt. With the changes in this PR, the output becomes:
This matches historic ex behavior and appears to match POSIX, though it is not 100% clear on this specific issue.