Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

AddVips::Image#close.#340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
ioquatix wants to merge1 commit intomaster
base:master
Choose a base branch
Loading
fromimage-close
Open

AddVips::Image#close.#340

ioquatix wants to merge1 commit intomasterfromimage-close

Conversation

ioquatix
Copy link
Member

I've been using this to help deal with memory usage issues.

dimroc reacted with thumbs up emoji
@ioquatixioquatix requested a review fromjcupittJune 24, 2022 07:01
@Nakilon
Copy link
Contributor

Hi. Just wondering. It is the thing that you've mentioned here?#67 (comment)
As I understand you said there it didn't help, only the GC.start did or something.

@ioquatix
Copy link
MemberAuthor

Wow that was a while ago.

Well, I have not run the benchmarks again. That being said, in theory a close method makes sense. In practice, more work might be needed to make it practical/useful.

@jcupitt
Copy link
Member

Hi, good idea, I've been meaning to add this.

Could we call itinvalidate? That's the name we've used in the other libvips bindings.

close is rather close topost_close, the name we use for cleanup-on-finalize handlers.

@jdelStrother
Copy link

Doesn't this also need aVips.attach_function :vips_image_invalidate_all, [:pointer], :void somewhere? Without it I get NoMethodError

ioquatix reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jcupittjcupittAwaiting requested review from jcupitt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@ioquatix@Nakilon@jcupitt@jdelStrother

[8]ページ先頭

©2009-2025 Movatter.jp