- Notifications
You must be signed in to change notification settings - Fork2.5k
fuzzers: Fix CFLAGS#7044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
fuzzers: Fix CFLAGS#7044
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
I'm seeing the current fuzzer build fail (during `cmake`) like so:```-- Performing Test IS_FSANITIZE_FUZZER_NO_LINK_SUPPORTED-- Performing Test IS_FSANITIZE_FUZZER_NO_LINK_SUPPORTED - FailedCMake Error at cmake/AddCFlagIfSupported.cmake:17 (message): Required flag -fsanitize=fuzzer-no-link is not supportedCall Stack (most recent call first): fuzzers/CMakeLists.txt:6 (add_c_flag)```The cmake log output contains something like so:``` /src/aflplusplus/libAFLDriver.a(aflpp_driver.o): in function `main': aflpp_driver.c:(.text+0x11b): undefined reference to `LLVMFuzzerTestOneInput' clang: error: linker command failed with exit code 1 (use -v to see invocation)```I haven't figured out exactly what's happening, but I believe thatonce line 5 has added `-fsanitize=fuzzer` to `CFLAGS`, future compile-tests **also** use it during linking. This in turn pulls in the fuzzer`main`, which expects an `LLVMFuzzerTestOneInput` symbol, and thusfails.Instead, just add `-fsanitize=fuzzer-no-link` to CFLAGS (as suggested[by the documentation][libfuzzer]), and then use `-fsanitize=fuzzer`only for linking the fuzzer targets. At least in my environment, thisresults in a working fuzzer build.[libfuzzer]:https://llvm.org/docs/LibFuzzer.html#fuzzer-usage
Seems reasonable; thanks for the fix and the explanation. |
de652db
intolibgit2:main 19 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm seeing the current fuzzer build fail (during
cmake
) like so:The cmake log output contains something like so:
I haven't figured out exactly what's happening, but I believe that once line 5 has added
-fsanitize=fuzzer
toCFLAGS
, future compile- testsalso use it during linking. This in turn pulls in the fuzzermain
, which expects anLLVMFuzzerTestOneInput
symbol, and thus fails.Instead, just add
-fsanitize=fuzzer-no-link
to CFLAGS (as suggestedby the documentation), and then use-fsanitize=fuzzer
only for linking the fuzzer targets. At least in my environment, this results in a working fuzzer build.