- Notifications
You must be signed in to change notification settings - Fork2.5k
Revert include path regression#7039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
7 tasks
eb22b60
intolibgit2:main 19 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Thanks for the fix! |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
I've upgraded to using libgit2 v1.9, and I've been getting build errors that weren't there previously. This is caused by the custom
<stdint.h>
header file.The build errors only occur when using ainstalled libgit2.
I am using Fedora Linux 41.
Example usage code
CMakeLists.txt
main.cpp
Trying to build this leads to errors like this:
Explanation
When using the installed libgit2 the include paths will now contain
include/git2
instead ofinclude
. This is problematic because there's a custom<stdint.h>
in thegit2
folder.Now any user code that has
#include <stdint.h>
, will now include the custom<stdint.h>
header instead of the standard one. Which causes the build error.Solution
This PR fixes this regression.