- Notifications
You must be signed in to change notification settings - Fork2.5k
Allow consumers to query the "backends" that libgit2 was built with#6971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Move the test for querying version information out of the`core::features` test and into the `core::version` test.
75b6665 to7bd1cb8CompareAdd the status of the zlib backend (builtin or external) to`git2_features.h`.
Provide a mechanism to understand the backend provider for featurewithin libgit2. For example, one can query the mechanism that providesHTTPS by asking for the backend for the `GIT_FEATURE_HTTPS`.This is particularly useful for features that are not completelyisomorphic; the HTTPS providers may have slightly differentfunctionality that can be controlled (eg, certificates or ciphersupport). And the SSH feature is _very_ different between libssh2 andOpenSSH.It may also be useful to understand the support for things like the SHA1or SHA256 backends to ensure that sha1dc is used, or that FIPS mode isenabled.
7bd1cb8 to19a031dCompare95dfb83 intomain 19 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide a mechanism to understand the backend provider for feature
within libgit2. For example, one can query the mechanism that provides
HTTPS by asking for the backend for the
GIT_FEATURE_HTTPS.This is particularly useful for features that are not completely
isomorphic; the HTTPS providers may have slightly different
functionality that can be controlled (eg, certificates or cipher
support). And the SSH feature isvery different between libssh2 and
OpenSSH.
It may also be useful to understand the support for things like the SHA1
or SHA256 backends to ensure that sha1dc is used, or that FIPS mode is
enabled.