NotificationsYou must be signed in to change notification settings
Fork2.5k
Star10k

util/win32: Continue if access is denied when deleting a folder.#6929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

ethomson merged 1 commit intolibgit2:mainfromlrm29:util_win32_rmdir_access_denied

Oct 29, 2024

Merged

util/win32: Continue if access is denied when deleting a folder.#6929

ethomson merged 1 commit intolibgit2:mainfromlrm29:util_win32_rmdir_access_denied

Oct 29, 2024

Conversation

Copy link

Contributor

lrm29 commentedOct 25, 2024•
edited
Loading

I'm afraid people do put Git repos on OneDrive... It seems to like to prevent folders from being deleted, causing libgit2 operations to handle ERROR_ACCESS_DENIED, and preventing us from switching branches/merging etc.

I think this change brings libgit2 in line with the behaviour of Git for Windows. The rmdir function is locatedhere. The function is_file_in_use_error not only checks for ERROR_SHARING_VIOLATION, but also ERROR_ACCESS_DENIED:

staticinlineintis_file_in_use_error(DWORD errcode){switch (errcode) {case ERROR_SHARING_VIOLATION:case ERROR_ACCESS_DENIED:return1;}return0;}

Completely understand any hesitation about merging this, but thought it might be useful to at least raise it so others can search for it. I've tried it out and it seems to work ok.

Of course, it means empty folders can end up lying around in your local Git repository which is also confusing. But Git for Windows is the same.