- Notifications
You must be signed in to change notification settings - Fork2.5k
hashmap: a libgit2-idiomatic khash#6897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This minor refactoring helps remove some of the coupling that pieceshave to the attribute cache.
Let callers understand whether a pool has been initialized or not.
Introduce `git_hashmap` and `git_hashset` functionality that is a portof `khash.h` to be more idiomatically libgit2. This gives us many of thebenefits of khash that we had abstracted away:1. Typesafety on the values, since we define the structs and functions2. Ability to create hashes on the stack3. Ability to new up hashmaps (or sets) without the libgit2 abstraction wrappers that we had been addingThis uses the macros to define hashes (either the structure, or thefunctions, or both) which is very much in the spirit of khash, butthe results are much more idiomatically libgit2.
Provide functions for `git_oid` to provide a 32 bit or 64 bit hashvalue, useful for a hashmap.
A hashmap that uses git_oid's as keys. Move the hashcode function out ofgit_oid.
5ead0bd intomain 19 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce
git_hashmapandgit_hashsetfunctionality that is a port ofkhash.hto be more idiomatically libgit2. This gives us many of the benefits of khash that we had abstracted away:This uses the macros to define hashes (either the structure, or the functions, or both) which is very much in the spirit of khash, but the results are much more idiomatically libgit2.