Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

repo: support the preciousObjects extension#6886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethomson merged 1 commit intomainfromethomson/preciousobjects
Sep 26, 2024

Conversation

ethomson
Copy link
Member

libgit2 implicitly supports precious objects, since there's no gc command, nor even any option in our object database functionality to delete an object from the odb.

In the future, when we support deleting objects, or a gc functionality, we will need to honor the preciousObjects extension and reject those APIs when it is set. In the meantime, since users cannot use libgit2 (directly) to delete an object, we can simply add this to our allowlist.

albfan and ao2 reacted with thumbs up emoji
@ethomson
Copy link
MemberAuthor

Fixes#6873 6873

libgit2 implicitly supports precious objects, since there's no gccommand, nor even any option in our object database functionality todelete an object from the odb.In the future, when we support deleting objects, or a gc functionality,we will need to honor the preciousObjects extension and reject thoseAPIs when it is set. In the meantime, since users cannot use libgit2(directly) to delete an object, we can simply add this to our allowlist.
@ethomsonethomson merged commit38eee39 intomainSep 26, 2024
19 checks passed
@ethomsonethomson deleted the ethomson/preciousobjects branchSeptember 26, 2024 19:30
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@ethomson

[8]ページ先頭

©2009-2025 Movatter.jp