NotificationsYou must be signed in to change notification settings
Fork2.5k
Star10k

transport: do not filter tags based on ref dir in local#6881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

ethomson merged 1 commit intolibgit2:mainfromrindeal:rindeal-patch-1

Sep 27, 2024

Merged

transport: do not filter tags based on ref dir in local#6881

ethomson merged 1 commit intolibgit2:mainfromrindeal:rindeal-patch-1

Sep 27, 2024

Conversation

Copy link

Contributor

rindeal commentedSep 12, 2024•
edited
Loading

Letgit_object_type() do the filtering instead.

Fixes:#6275

Copy link

Member

ethomson commentedSep 25, 2024

Hi@rindeal! This seems like it makes sense! The tests are failing, though - are the tests wrong (and should have been reporting these refs in the first place?) or is the implementation not quite right?

transport: do not filter tags based on ref dir in local

656e751

Let git_object_type() do the filtering instead.Fixes:libgit2#6275

rindeal force-pushed therindeal-patch-1 branch fromc651b77 to656e751Compare

September 25, 2024 14:45

Copy link

ContributorAuthor

rindeal commentedSep 25, 2024

Hi@rindeal! This seems like it makes sense! The tests are failing, though - are the tests wrong (and should have been reporting these refs in the first place?) or is the implementation not quite right?

As detailed in the linked issue, the function wasn't peelingrefs/blobs/annotated_tag_to_blob, resulting in the output being one line shorter. I've updated the tests so all should be well now.

Copy link

Member

ethomson commentedSep 27, 2024

As detailed in the linked issue, the function wasn't peeling refs/blobs/annotated_tag_to_blob, resulting in the output being one line shorter. I've updated the tests so all should be well now.

Ah, thanks, I think that I may have noticed that in my initial review and forgotten when I came back to this. In any case, very cool, thanks for the fix.