- Notifications
You must be signed in to change notification settings - Fork2.5k
Make packbuilder interruptible using progress callback#6874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Specifically, forward errors from packbuilder->progress_cbThis allows the callback to gracefully terminate long-runningoperations when the application is interrupted.Interruption could be ^C in the terminal, but this could be anyother condition or event, as this is up to the callback functionto implement.
This was referencedSep 2, 2024
Helpful fix, thanks! |
75e670d intolibgit2:main 19 checks passed
Uh oh!
There was an error while loading.Please reload this page.
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifically, forward errors from
packbuilder->progress_cbThis allows the callback to gracefully terminate long-running operations when the application is interrupted.
Interruption could be
^Cin the terminal, but this could be any other condition or event, as this is up to the callback function to implement.My specific motivation for this is to improve the responsiveness of the Nix package manager to interrupts in the terminal, in the context ofNixOS/nix#11330, which proposes to write packfiles instead of loose objects for performance.