NotificationsYou must be signed in to change notification settings
Fork2.5k
Star10k

Add SecCopyErrorMessageString for iOS and update README for iOS#6862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

ethomson merged 13 commits intolibgit2:mainfromKyle-Ye:optimize/ios

Sep 26, 2024

Merged

Add SecCopyErrorMessageString for iOS and update README for iOS#6862

ethomson merged 13 commits intolibgit2:mainfromKyle-Ye:optimize/ios

Sep 26, 2024

Conversation

Copy link

Contributor

Kyle-Ye commentedAug 17, 2024•
edited
Loading

Add iOS build instruction in README
Fix iOS build issue
Add SecCopyErrorMessageString API when building for iOS

Close#6861

Copy link

ContributorAuthor

Kyle-Ye commentedAug 18, 2024•
edited
Loading

Some notes for the reviewer:

Do we want to add iOS CI check here?
There is a flaky Windows test case failing. Maybe a rerun will temporary pass it.
Experimental Features / Build: Windows (SHA256, amd64, Visual Studio) (pull_request)
The iOS CI is failing due to a permission issue

ln: /usr/local/lib: Permission denied

I'll align the host os to macos-12 as the same version of the existing macOS CI to try to fix it.

Is it OK have a dependency on master branch of eetal/ios-cmake for the iOS CI?

Kyle-Ye force-pushed theoptimize/ios branch 2 times, most recently from3a8ba3c tod7dc82fCompare

August 24, 2024 06:25

Kyle-Ye added7 commits

September 5, 2024 00:07

Add iOS build instruction in README

e5da881

Fix iOS build issue

4b63eb5

Add SecCopyErrorMessageString API when building for iOS

8957d36

SecCopyErrorMessageString is supported since iOS 11.3.I believe we do not need to use #if check here since the default IPHONEOS_DEPLOYMENT_TARGET is iOS 13.0 for Xcode 15.3.

Add iOS CI support

06a9dc9

Align the iOS CI’s host OS version to fix the permission issue

60cdd25

Fix CI toolchain file location issue

07bb47c

Fix regcomp_l compile issue

841164e

Kyle-Ye force-pushed theoptimize/ios branch fromd7dc82f to841164eCompare

September 4, 2024 16:08

Fix iconv link issue

871208e

Copy link

Contributor

Uncommon commentedSep 5, 2024

Are these changes actually specific to iOS, or do they apply to macOS as well?

Copy link

ContributorAuthor

Kyle-Ye commentedSep 5, 2024

Are these changes actually specific to iOS, or do they apply to macOS as well?

specific to iOS

Kyle-Ye marked this pull request as ready for review

September 5, 2024 16:29

Copy link

ContributorAuthor

Kyle-Ye commentedSep 5, 2024•
edited
Loading

The CI is failing due to libgit2_tests issue.

It will bebuild/libgit2_tests.app/libgit2_tests instead ofbuild/libgit2_tests for iOS.

And we can fix it by modifyingtests/libgit2/CMakeLists.txt. But it will then be killed since it is an iOS app and we are running it directly on macOS.

1 - offline (Subprocess killed)

I suggest for now we just skip the tests on iOS and add them back later.

Kyle-Ye added3 commits

September 6, 2024 00:42

Fix system API issue

7fb1c8e

Fix rt linker issue

b83d55c

Skip all test on iOS temporarily

10c424f

Kyle-Ye force-pushed theoptimize/ios branch from3e369ab to10c424fCompare

September 5, 2024 16:43

Copy link

Member

ethomson commentedSep 6, 2024

I suggest for now we just skip the tests on iOS and add them back later.

👍

Thanks; I want to figure out how this integrates with#6848 since they're touching roughly the same bits of code. Will get these both merged this weekend. Thanks for this effort!

ethomson added2 commits

September 26, 2024 16:48

Merge remote-tracking branch 'origin/main' into securetransport

851628f

iOS Updates

41f6f72

Some minor refactoring for iOS:- Roll back clar changes; these should be a bit more measured, and occur  in clar upstream.- Move iOS to nightly builds

Copy link

Member

ethomson commentedSep 26, 2024

Thanks! I moved the iOS build into the nightlies, and I reverted the clar changes so that we could think a bit more how (or if) we would address iOS on clar.