Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Headers cleanup#6842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethomson merged 2 commits intolibgit2:mainfromanatol:main
Jul 12, 2024
Merged

Headers cleanup#6842

ethomson merged 2 commits intolibgit2:mainfromanatol:main
Jul 12, 2024

Conversation

anatol
Copy link
Contributor

A small cleanup for libgit2 headers

@ethomson
Copy link
Member

Oops, good catch onemail_from_diff. It was actually supposed to be in thesys/email.h header. Would you mind zapping it fromemail.h instead? 🙏

@anatol
Copy link
ContributorAuthor

Oops, good catch onemail_from_diff. It was actually supposed to be in thesys/email.h header. Would you mind zapping it fromemail.h instead? 🙏

Sure, done. It turns there are some users that expect the function to be atgit2/mail.h, so I fixed them as well.

@ethomson
Copy link
Member

Awesome, thanks! 🙏

This makes the function signature consistent with other cases
Exactly the same function already declared in include/git2/email.h
@anatol
Copy link
ContributorAuthor

@ethomson could you please approve the github workflow to see if my last patch fixes the compilation issue?

@ethomson
Copy link
Member

Thanks!

@ethomsonethomson merged commitd58db64 intolibgit2:mainJul 12, 2024
19 checks passed
@ethomsonethomson added the bug labelSep 29, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@anatol@ethomson
[8]ページ先頭
©2009-2025 Movatter.jp