- Notifications
You must be signed in to change notification settings - Fork2.5k
odb: conditional git_hash_ctx_cleanup in git_odb_stream#6836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
When `git_odb_stream` is a read stream, `hash_ctx` is not used.Therefore, check if `hash_ctx` can be freed during the release.This allows implementers of custom ODB backends to not worry aboutthe creation of `hash_ctx` for now.
585210a intolibgit2:main 19 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Thanks! |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in#6835
When
git_odb_streamis a read stream,hash_ctxis not used. Therefore, check ifhash_ctxcan be freed during the release. This allows implementers of custom ODB backends to not worry about the creation ofhash_ctxfor now.