- Notifications
You must be signed in to change notification settings - Fork2.5k
Introduce a stricter debugging allocator for testing#6811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Instead of tweaking the `stdalloc` allocator when`GIT_DEBUG_STRICT_ALLOC` is defined, actually create a debuggingallocator. This allows us to ensure that we are strict about things likenot expecting `malloc(0)` to do something useful, but we can alsointroduce an excessively pedantic `realloc` implementation that _always_creates a new buffer, throws away its original `ptr`, and overwrites thedata that's there with garbage. This may be helpful to identify placesthat make assumptions about realloc.
realpath(3) _may_ allocate strings (if the second param is NULL) usingthe system allocator. However, callers need an assurance that they canfree memory using git__free. If we made realpath do an allocation, thenmake sure that we strdup it into our allocator's memory.More importantly, avoid this behavior by always providing a buffer top_realpath invocations.
Instead of setting the allocator to stdalloc, just pass `NULL`, in casewe're running with the debug allocator.
a491724
toabedcfe
CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a new debugging allocator that:
malloc
isnot the same pointer that the underlying systemmalloc
used, and is therefore incompatible with the systemfree
. This helps catch inconsistent use of system malloc and the libgit2-configured malloc.realloc
to always reallocate (it will explicitlymalloc
,memcpy
, andfree
the previous pointer)Also, update some inconsistent use of allocators caught by 1.