- Notifications
You must be signed in to change notification settings - Fork2.5k
Correctgit_revparse_single and add revparse fuzzing#6730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Many fuzzers will need to operate with a repository; extract therepository initialization from downloads_refs_fuzzer.c into its ownutility area.
If there are no caps, don't try to advance past the first NULL to lookfor object-format. This prevents a possible out-of-bounds read.
When parsing a revspec that ends with a trailing `@`, explicitly stopparsing. Introduce a sentinel variable to explicitly stop parsing.Prior to this, we would set `spec` to `HEAD`, but were looping on thevalue of `spec[pos]`, so we would continue walking the (new) `spec`at offset `pos`, looking for a NUL. This is obviously an out-of-boundsread.Credit to Michael Rodler (@f0rki) and Amazon AWS Security.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce address sanitization during builds. Surprisingly, although we enabled various sanitizers (thread, memory, undefinedbehavior) we didnot have address sanitizer running. Add that.
Address sanitizer correctly detected a failure to correctly parse capabilities in a first pkt. In our test corpus we have a message with no capabilities (the length of the message is the ref advertisement plus a trailing NUL). We walk off the end of that string trying to read capabilities. Now we honor the
lenbefore checking for caps.Update revparse to correctly stop parsing
specwhen we find a trailing@. Thanks to the Amazon AWS Security team for finding and responsibly disclosing this.