- Notifications
You must be signed in to change notification settings - Fork2.5k
set SSH timeout#6721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
set SSH timeout#6721
Uh oh!
There was an error while loading.Please reload this page.
Conversation
src/libgit2/transports/ssh_libssh2.c Outdated
| @@ -539,6 +541,10 @@ static int _git_ssh_session_create( | |||
| return -1; | |||
| } | |||
| if (git_socket_stream__connect_timeout > 0) { | |||
| libssh2_session_set_timeout(s, git_socket_stream__connect_timeout); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We should inherit thegit_socket_stream__connect_timeout from the socket stream. So we already have connection timeouts.
I think that for this, we want to useGIT_OPT_SET_SERVER_TIMEOUT. So I think that this should begit_socket_stream__timeout instead...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
updated PR
The connect timeout *does* apply to SSH connections (at least libssh2),so update the documentation appropriately.
Looks great — I added one change to the docs that is related but independent. (They stated that the connect timeout was not supported for SSH, in fact, it is.) Thanks for the PR! 🎉 |
fixes#6708 ?