NotificationsYou must be signed in to change notification settings
Fork2.5k
Star10k

push: set generic error in push_negotiation cb#6675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

ethomson merged 1 commit intomainfromethomson/push_cancel

Dec 14, 2023

Merged

push: set generic error in push_negotiation cb#6675

ethomson merged 1 commit intomainfromethomson/push_cancel

Dec 14, 2023

Conversation

Copy link

Member

ethomson commentedDec 14, 2023

When a user returns-1 in apush_negotiation callback, we set the error to whatever's hanging out in the buffer, probably something about a missing configuration entry.

Clear the error buffer before invoking the callback, so that if a user does not set an error message in their callback that we can detect. If there is no error but-1 is returned, set a generic error message.

Fixes#6672

push: set generic error in push_negotiation cb

8b7495f

When a user returns `-1` in a `push_negotiation` callback, we set theerror to whatever's hanging out in the buffer, probably something abouta missing configuration entry.Clear the error buffer before invoking the callback, so that if a userdoes not set an error message in their callback that we can detect. Ifthere is no error but `-1` is returned, set a generic error message.