NotificationsYou must be signed in to change notification settings
Fork2.5k
Star10k

Support setting oid type for in-memory repositories#6671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

ethomson merged 1 commit intolibgit2:mainfromkcsaul:repo_new_oid_type

Dec 14, 2023

Merged

Support setting oid type for in-memory repositories#6671

ethomson merged 1 commit intolibgit2:mainfromkcsaul:repo_new_oid_type

Dec 14, 2023

Conversation

Copy link

Contributor

kcsaul commentedDec 14, 2023

This change adds support for setting oid type when creating an in-memory repository using git_repository_new (in conjunction with using custom backends).

Needed to prevent "ambiguous lookup - OID prefix is too short" error during git_object_lookup_prefix.

repo: add oid type support to git_repository_new

731af14

kcsaul force-pushed therepo_new_oid_type branch from34c4f47 to731af14Compare

December 14, 2023 04:00

Copy link

Member

ethomson commentedDec 14, 2023

Great catch. Thanks for the fix.

I wonder if we should take agit_repository_new_options here? The name is a bit regrettable, but matches our style. This could help future-proof that API in case we want to add more things later.

Copy link

ContributorAuthor

@ethomson - I'd wondered the same thing, but as it appears the basic purpose of git_repository_new is similar to git_index_new for the creation of blank/in-memory structure, it seemed sufficient to take the same approach as git_index_new for the time being at least.

Could be revised if needed later with minimal disruption while it's still behind the experimental feature toggle. My immediate goal was getting things working for my existing use case without the experimental flag enabled as part of upgrading to latest version.